public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rasmus Villemoes <ravi@prevas.dk>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de,
	 Anatolij Gustschin <ag.dev.uboot@gmail.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Ion Agorria <ion@agorria.com>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Patrice Chotard <patrice.chotard@foss.st.com>,
	 Svyatoslav Ryhel <clamor95@gmail.com>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 2/2] kbuild: Use relative paths in generated .incbin directives
Date: Fri, 27 Mar 2026 09:12:35 +0100	[thread overview]
Message-ID: <87cy0plmh8.fsf@prevas.dk> (raw)
In-Reply-To: <20260326115500.955388-2-sjg@chromium.org> (Simon Glass's message of "Thu, 26 Mar 2026 05:54:57 -0600")

On Thu, Mar 26 2026, Simon Glass <sjg@chromium.org> wrote:

> The generated .S files for fonts and splash screens use .incbin with the
> full prerequisite path. When building with O= this bakes an absolute
> path into the .S file. If the build directory is later used on a
> different machine (e.g. in a container), the assembler cannot find the
> source file.

I must be missing something, because I can't see how this can be a
problem, while all the other absolute paths to the source dir that go
into files generated in the build directory is not. For example, there's
a top-level "source -> /path/to/u-boot" symlink created, and as far as I
can tell, all the .foo.o.cmd files end up full of such references as
well, e.g. $BUILD/lib/.vsprintf.o.cmd contains

source_lib/vsprintf.o := /path/to/u-boot/lib/vsprintf.c

Also, in practice, I'd expect the .o file to be generated from the .S
file immediately, so make should never even invoke the assembler to
build the .o from the .S that has a "stale" reference to the source dir
- though you can of course explicitly make the .S file in one container,
then try to do the full build in another, which would IMO be solidly in
"don't do that then" land.

So can you show me an actual sequence of commands and container
invocations where building a u-boot configuration without any of these
font files in play works, but those absolute paths in the generated .S
files breaks? I.e., which paths are the source and build dirs mapped to
in the two containers, how and where do you invoke make (make O=... in
the source tree or just make in the build dir?), etc.

Rasmus

  reply	other threads:[~2026-03-27  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 11:54 [PATCH v2 1/2] kbuild: Move U-Boot .incbin rules to Makefile.lib-u-boot Simon Glass
2026-03-26 11:54 ` [PATCH v2 2/2] kbuild: Use relative paths in generated .incbin directives Simon Glass
2026-03-27  8:12   ` Rasmus Villemoes [this message]
2026-03-27 10:27     ` Rasmus Villemoes
2026-03-27 12:44       ` Simon Glass
2026-03-27 14:46         ` Rasmus Villemoes
2026-03-26 11:57 ` [PATCH v2 1/2] kbuild: Move U-Boot .incbin rules to Makefile.lib-u-boot Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy0plmh8.fsf@prevas.dk \
    --to=ravi@prevas.dk \
    --cc=ag.dev.uboot@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=ion@agorria.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox