From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Simon Holesch <simon@holesch.de>, Lukasz Majewski <lukma@denx.de>,
Marek Vasut <marex@denx.de>
Cc: Simon Holesch <simon@holesch.de>, u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/2] usb: fastboot: Add missing newline in pr_err
Date: Tue, 21 Nov 2023 09:17:41 +0100 [thread overview]
Message-ID: <87cyw3msey.fsf@baylibre.com> (raw)
In-Reply-To: <20231120002024.32865-2-simon@holesch.de>
Hi Simon,
Thank you for your patch.
On lun., nov. 20, 2023 at 01:08, Simon Holesch <simon@holesch.de> wrote:
> Add missing newline in pr_err.
>
> Signed-off-by: Simon Holesch <simon@holesch.de>
> Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>
> Changes in v2:
> - add commit message body
>
> Thanks for the review!
>
> drivers/usb/gadget/f_fastboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index 741775a7bc..9f322c9550 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -520,7 +520,7 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req)
> cmdbuf[req->actual] = '\0';
> cmd = fastboot_handle_command(cmdbuf, response);
> } else {
> - pr_err("buffer overflow");
> + pr_err("buffer overflow\n");
> fastboot_fail("buffer overflow", response);
> }
>
> --
> 2.42.1
next prev parent reply other threads:[~2023-11-21 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 0:08 [PATCH v2 1/2] usb: ci: Fix gadget reinit Simon Holesch
2023-11-20 0:08 ` [PATCH v2 2/2] usb: fastboot: Add missing newline in pr_err Simon Holesch
2023-11-20 2:07 ` Marek Vasut
2023-11-21 8:18 ` Mattijs Korpershoek
2023-11-21 8:17 ` Mattijs Korpershoek [this message]
2023-11-21 8:15 ` [PATCH v2 1/2] usb: ci: Fix gadget reinit Mattijs Korpershoek
2023-11-21 8:21 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyw3msey.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=simon@holesch.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox