* [PATCH v5 39/43] command: Include a required header in command.h
@ 2023-09-27 14:22 Simon Glass
2023-09-30 8:41 ` Mattijs Korpershoek
2023-10-07 14:17 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Simon Glass @ 2023-09-27 14:22 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Marek Vasut, Tom Rini, Simon Glass, Evgeny Bachinin,
Heinrich Schuchardt, Marek Vasut, Mattijs Korpershoek,
Safae Ouajih
This uses ARRAY_SIZE() but does not include the header file which declares
it. Fix this, so that command.h can be included without common.h
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v5:
- Adjust so this builds on azure
boot/bootm.c | 2 +-
include/command.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/boot/bootm.c b/boot/bootm.c
index b1c3afe0a3a..8f96a80d425 100644
--- a/boot/bootm.c
+++ b/boot/bootm.c
@@ -8,6 +8,7 @@
#include <common.h>
#include <bootstage.h>
#include <cli.h>
+#include <command.h>
#include <cpu_func.h>
#include <env.h>
#include <errno.h>
@@ -29,7 +30,6 @@
#include "mkimage.h"
#endif
-#include <command.h>
#include <bootm.h>
#include <image.h>
diff --git a/include/command.h b/include/command.h
index ae7bb4a30b0..34ea989b39b 100644
--- a/include/command.h
+++ b/include/command.h
@@ -25,6 +25,10 @@
#endif
#ifndef __ASSEMBLY__
+
+/* For ARRAY_SIZE() */
+#include <linux/kernel.h>
+
/*
* Monitor Command Table
*/
--
2.42.0.515.g380fc7ccd1-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5 39/43] command: Include a required header in command.h
2023-09-27 14:22 [PATCH v5 39/43] command: Include a required header in command.h Simon Glass
@ 2023-09-30 8:41 ` Mattijs Korpershoek
2023-10-07 14:17 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2023-09-30 8:41 UTC (permalink / raw)
To: Simon Glass, U-Boot Mailing List
Cc: Marek Vasut, Tom Rini, Simon Glass, Evgeny Bachinin,
Heinrich Schuchardt, Marek Vasut, Safae Ouajih
On mer., sept. 27, 2023 at 08:22, Simon Glass <sjg@chromium.org> wrote:
> This uses ARRAY_SIZE() but does not include the header file which declares
> it. Fix this, so that command.h can be included without common.h
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>
> Changes in v5:
> - Adjust so this builds on azure
>
> boot/bootm.c | 2 +-
> include/command.h | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/boot/bootm.c b/boot/bootm.c
> index b1c3afe0a3a..8f96a80d425 100644
> --- a/boot/bootm.c
> +++ b/boot/bootm.c
> @@ -8,6 +8,7 @@
> #include <common.h>
> #include <bootstage.h>
> #include <cli.h>
> +#include <command.h>
> #include <cpu_func.h>
> #include <env.h>
> #include <errno.h>
> @@ -29,7 +30,6 @@
> #include "mkimage.h"
> #endif
>
> -#include <command.h>
> #include <bootm.h>
> #include <image.h>
>
> diff --git a/include/command.h b/include/command.h
> index ae7bb4a30b0..34ea989b39b 100644
> --- a/include/command.h
> +++ b/include/command.h
> @@ -25,6 +25,10 @@
> #endif
>
> #ifndef __ASSEMBLY__
> +
> +/* For ARRAY_SIZE() */
> +#include <linux/kernel.h>
> +
> /*
> * Monitor Command Table
> */
> --
> 2.42.0.515.g380fc7ccd1-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 39/43] command: Include a required header in command.h
2023-09-27 14:22 [PATCH v5 39/43] command: Include a required header in command.h Simon Glass
2023-09-30 8:41 ` Mattijs Korpershoek
@ 2023-10-07 14:17 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-10-07 14:17 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, Marek Vasut, Evgeny Bachinin,
Heinrich Schuchardt, Marek Vasut, Mattijs Korpershoek,
Safae Ouajih
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
On Wed, Sep 27, 2023 at 08:22:37AM -0600, Simon Glass wrote:
> This uses ARRAY_SIZE() but does not include the header file which declares
> it. Fix this, so that command.h can be included without common.h
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-07 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 14:22 [PATCH v5 39/43] command: Include a required header in command.h Simon Glass
2023-09-30 8:41 ` Mattijs Korpershoek
2023-10-07 14:17 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox