public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Nishanth Menon <nm@ti.com>, Neha Francis <n-francis@ti.com>,
	Tom Rini <trini@konsulko.com>, Simon Glass <sjg@google.com>
Cc: Bryan <bb@ti.com>, Praneeth <praneeth@ti.com>,
	Andrew <afd@ti.com>, Robert Nelson <robertcnelson@gmail.com>,
	Vignesh <vigneshr@ti.com>,
	u-boot@lists.denx.de, Jan Kiszka <jan.kiszka@siemens.com>,
	Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH V5 07/17] include: env: ti: ti_armv7_common.env: Rename to ti_common.env
Date: Thu, 24 Aug 2023 10:29:37 +0200	[thread overview]
Message-ID: <87cyzcrgge.fsf@baylibre.com> (raw)
In-Reply-To: <20230824031101.3460411-8-nm@ti.com>

On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote:

> ti_armv7_common does not make any more sense as it is used by armv7
> and armv8 TI based platforms.
>
> Reported-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> New patch review comment from:
> https://lore.kernel.org/all/20230823144257.GG3953269@bill-the-cat/
>
> ti_common.h does'nt need any header file support if we switch to
> bootstd.
>
>  board/siemens/iot2050/iot2050.env                     | 2 +-
>  board/ti/am62ax/am62ax.env                            | 2 +-
>  board/ti/am62x/am62x.env                              | 2 +-
>  board/ti/am64x/am64x.env                              | 2 +-
>  board/ti/am65x/am65x.env                              | 2 +-
>  board/ti/j721e/j721e.env                              | 2 +-
>  board/ti/j721s2/j721s2.env                            | 2 +-
>  board/ti/ks2_evm/k2e_evm.env                          | 2 +-
>  board/ti/ks2_evm/k2g_evm.env                          | 2 +-
>  board/ti/ks2_evm/k2hk_evm.env                         | 2 +-
>  board/ti/ks2_evm/k2l_evm.env                          | 2 +-
>  include/env/ti/{ti_armv7_common.env => ti_common.env} | 0
>  12 files changed, 11 insertions(+), 11 deletions(-)
>  rename include/env/ti/{ti_armv7_common.env => ti_common.env} (100%)
>
> diff --git a/board/siemens/iot2050/iot2050.env b/board/siemens/iot2050/iot2050.env
> index caa9f80e3fca..8bbd7abe98f0 100644
> --- a/board/siemens/iot2050/iot2050.env
> +++ b/board/siemens/iot2050/iot2050.env
> @@ -6,7 +6,7 @@
>   *   Jan Kiszka <jan.kiszka@siemens.com>
>   */
>  
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  
>  usb_pgood_delay=900
>  
> diff --git a/board/ti/am62ax/am62ax.env b/board/ti/am62ax/am62ax.env
> index 3f7c333fa404..bfed7f360844 100644
> --- a/board/ti/am62ax/am62ax.env
> +++ b/board/ti/am62ax/am62ax.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
>  
>  default_device_tree=ti/k3-am62a7-sk.dtb
> diff --git a/board/ti/am62x/am62x.env b/board/ti/am62x/am62x.env
> index 1cf56dbd8128..1ef948df83d7 100644
> --- a/board/ti/am62x/am62x.env
> +++ b/board/ti/am62x/am62x.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
>  
>  default_device_tree=ti/k3-am625-sk.dtb
> diff --git a/board/ti/am64x/am64x.env b/board/ti/am64x/am64x.env
> index 1567907fcbdc..68e42222b7f1 100644
> --- a/board/ti/am64x/am64x.env
> +++ b/board/ti/am64x/am64x.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
>  #include <env/ti/k3_dfu.env>
>  
> diff --git a/board/ti/am65x/am65x.env b/board/ti/am65x/am65x.env
> index 755bff2707c8..286b9c300c05 100644
> --- a/board/ti/am65x/am65x.env
> +++ b/board/ti/am65x/am65x.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
>  #include <env/ti/k3_dfu.env>
>  #if CONFIG_CMD_REMOTEPROC
> diff --git a/board/ti/j721e/j721e.env b/board/ti/j721e/j721e.env
> index 2f2fb0591279..8cc8232fc131 100644
> --- a/board/ti/j721e/j721e.env
> +++ b/board/ti/j721e/j721e.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
>  #include <env/ti/ufs.env>
>  #include <env/ti/k3_dfu.env>
> diff --git a/board/ti/j721s2/j721s2.env b/board/ti/j721s2/j721s2.env
> index 6825b1469854..64e3d9da85f0 100644
> --- a/board/ti/j721s2/j721s2.env
> +++ b/board/ti/j721s2/j721s2.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
>  #include <env/ti/ufs.env>
>  #include <env/ti/k3_dfu.env>
> diff --git a/board/ti/ks2_evm/k2e_evm.env b/board/ti/ks2_evm/k2e_evm.env
> index a145db53e5fa..3dbb7934c59a 100644
> --- a/board/ti/ks2_evm/k2e_evm.env
> +++ b/board/ti/ks2_evm/k2e_evm.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/ti_armv7_keystone2.env>
>  
>  findfdt=setenv fdtfile ${name_fdt}
> diff --git a/board/ti/ks2_evm/k2g_evm.env b/board/ti/ks2_evm/k2g_evm.env
> index 4f4941dd0907..2b500fc6edf6 100644
> --- a/board/ti/ks2_evm/k2g_evm.env
> +++ b/board/ti/ks2_evm/k2g_evm.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/ti_armv7_keystone2.env>
>  #include <env/ti/mmc.env>
>  
> diff --git a/board/ti/ks2_evm/k2hk_evm.env b/board/ti/ks2_evm/k2hk_evm.env
> index 0714a51090ef..9991b76f8fcc 100644
> --- a/board/ti/ks2_evm/k2hk_evm.env
> +++ b/board/ti/ks2_evm/k2hk_evm.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/ti_armv7_keystone2.env>
>  
>  findfdt=setenv fdtfile ${name_fdt}
> diff --git a/board/ti/ks2_evm/k2l_evm.env b/board/ti/ks2_evm/k2l_evm.env
> index e8a803a4ed76..4e2debca4bde 100644
> --- a/board/ti/ks2_evm/k2l_evm.env
> +++ b/board/ti/ks2_evm/k2l_evm.env
> @@ -1,4 +1,4 @@
> -#include <env/ti/ti_armv7_common.env>
> +#include <env/ti/ti_common.env>
>  #include <env/ti/ti_armv7_keystone2.env>
>  
>  findfdt=setenv fdtfile ${name_fdt}
> diff --git a/include/env/ti/ti_armv7_common.env b/include/env/ti/ti_common.env
> similarity index 100%
> rename from include/env/ti/ti_armv7_common.env
> rename to include/env/ti/ti_common.env
> -- 
> 2.40.0

  reply	other threads:[~2023-08-24  8:29 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  3:10 [PATCH V5 00/17] board: ti: Add support for BeaglePlay Nishanth Menon
2023-08-24  3:10 ` [PATCH V5 01/17] include: configs: ti_armv7_common: Add documentation for protected section Nishanth Menon
2023-08-24  8:06   ` Mattijs Korpershoek
2023-08-24  3:10 ` [PATCH V5 02/17] include: configs: am62x_evm: Drop unused SDRAM address Nishanth Menon
2023-08-24  8:13   ` Mattijs Korpershoek
2023-08-24 12:05     ` Nishanth Menon
2023-08-24 13:02       ` Marcel Ziswiler
2023-08-24 16:09         ` Francesco Dolcini
2023-08-24 16:15           ` Francesco Dolcini
2023-08-28 21:56             ` Marcel Ziswiler
2023-08-24  3:10 ` [PATCH V5 03/17] include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS Nishanth Menon
2023-08-24 14:53   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 04/17] board: ti: am62x: am62x.env: Add explicit boot_targets Nishanth Menon
2023-08-24  3:10 ` [PATCH V5 05/17] configs: am62x_evm_a53_defconfig: Switch to bootstd Nishanth Menon
2023-08-24 14:54   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 06/17] include: configs: am62x_evm: Drop distro_bootcmd usage Nishanth Menon
2023-08-24 14:54   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 07/17] include: env: ti: ti_armv7_common.env: Rename to ti_common.env Nishanth Menon
2023-08-24  8:29   ` Mattijs Korpershoek [this message]
2023-08-24 14:55   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 08/17] include: env: ti: ti_common: Add a generic findfdt Nishanth Menon
2023-08-24 15:14   ` Tom Rini
2023-08-24 16:22     ` Nishanth Menon
2023-08-24 16:29       ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 09/17] board: ti: am62x: am62x.env: Use default findfdt Nishanth Menon
2023-08-24 15:14   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 10/17] arm: mach-k3: am625_init: Use IS_ENABLED() Nishanth Menon
2023-08-24  8:34   ` Mattijs Korpershoek
2023-08-24 15:14   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 11/17] arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static Nishanth Menon
2023-08-24  8:36   ` Mattijs Korpershoek
2023-08-24 15:14   ` Tom Rini
2023-08-24  3:10 ` [PATCH V5 12/17] configs: am62x_evm*: Enable EMMC_BOOT configuration Nishanth Menon
2023-08-24  3:10 ` [PATCH V5 13/17] arm: mach-k3: am625: Add support for UDA FS Nishanth Menon
2023-08-24  8:39   ` Mattijs Korpershoek
2023-08-24  3:10 ` [PATCH V5 14/17] arm: dts: k3-am625-sk-binman: Add labels for unsigned binary Nishanth Menon
2023-08-24  3:10 ` [PATCH V5 15/17] arm: dts: Add k3-am625-beagleplay Nishanth Menon
2023-08-24  3:11 ` [PATCH V5 16/17] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file Nishanth Menon
2023-08-24  8:43   ` Mattijs Korpershoek
2023-08-24 21:53   ` [PATCH] board: ti: am62x: beagleplay: Disable semi-functional PSCI reset support Jan Kiszka
2023-08-24 21:58     ` Tom Rini
2023-08-25  1:16       ` Nishanth Menon
2023-08-24  3:11 ` [PATCH V5 17/17] doc: board: ti: Add BeaglePlay documentation Nishanth Menon
2023-08-24  3:31 ` [PATCH V5 00/17] board: ti: Add support for BeaglePlay Nishanth Menon
2023-08-24  8:02 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyzcrgge.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=jan.kiszka@siemens.com \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=sjg@google.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox