From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E6B9C61DA3 for ; Tue, 21 Feb 2023 23:28:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5EC66859EE; Wed, 22 Feb 2023 00:28:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=debian.org header.i=@debian.org header.b="XnePJfgl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5AA288590F; Wed, 22 Feb 2023 00:28:48 +0100 (CET) Received: from cascadia.aikidev.net (cascadia.aikidev.net [IPv6:2600:3c01:e000:267:0:a171:de7:c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 18C31800B1 for ; Wed, 22 Feb 2023 00:28:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 893651AB8C; Tue, 21 Feb 2023 15:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1677022122; bh=kU7OG5pOa72REst6IelP5QCU41w2A4NPq8yuuumeosg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XnePJfgl/YEUGNT7+GS/uS6jzSRMTmATOAWZggo5fAxnxMUObe5n3oCkaJGmXZE9n UrUWvxHY+V1Wrr7Ipreaqhf6JoaFaO4fjtOe3jv8BznZJp2n4nsbsd4NabHKc1TjEp njURlmM6gWkecCqw2dePfxpmUgBi51uBlJZMB39R1kyfgUO3+QCXocK6kdiMNm3Y/t YJkF3aiWmbMc3a8DX3hMD4djZR3y5upAmSxnI5ToEWwJG35qtWZbEZ2iaVA4NiZznc V6y4DQY4B4ydqdKuuvHvzEVtIbadRxxLyfJtOagmvAPLrUfmFW3HsE0BY4Ld22u7Op pSj2XzaDBd6eA== From: Vagrant Cascadian To: Simon Glass , U-Boot Mailing List Cc: huang lin , Jeffy Chen , Simon Glass , Kever Yang , Philipp Tomsich , Tom Rini , Akash Gajjar , Jagan Teki Subject: Re: [PATCH 1/3] rockchip: Drop bootstage stash in TPL and SPL In-Reply-To: <20230221193920.3546499-1-sjg@chromium.org> References: <20230221193920.3546499-1-sjg@chromium.org> Date: Tue, 21 Feb 2023 15:28:37 -0800 Message-ID: <87cz62r42i.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-02-21, Simon Glass wrote: > Unfortunately the IRAM used to stash the bootstage records in TPL > becomes accessible after SPL runs. Presumably this is because of ATF > taking it over. > > We could move the stash to another address in SPL, before passing it to > U-Boot proper. But it seems easier to wait until we have support for > standard passage[1] which should not be too far away. > > For now, disable it in TPL and SPL. > > [1] https://patchwork.ozlabs.org/project/uboot/cover/ > 20220117150428.1580273-1-sjg@chromium.org/ > > Signed-off-by: Simon Glass Works for booting rockpro64-rk3399, thanks! Tested-by: Vagrant Cascadian > configs/rockpro64-rk3399_defconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk339= 9_defconfig > index dd67f9dff64..49614236819 100644 > --- a/configs/rockpro64-rk3399_defconfig > +++ b/configs/rockpro64-rk3399_defconfig > @@ -13,7 +13,6 @@ CONFIG_DM_RESET=3Dy > CONFIG_ROCKCHIP_RK3399=3Dy > CONFIG_TARGET_ROCKPRO64_RK3399=3Dy > CONFIG_SPL_STACK=3D0x400000 > -CONFIG_BOOTSTAGE_STASH_ADDR=3D0xff8e0000 > CONFIG_DEBUG_UART_BASE=3D0xFF1A0000 > CONFIG_DEBUG_UART_CLOCK=3D24000000 > CONFIG_SPL_SPI_FLASH_SUPPORT=3Dy > @@ -21,11 +20,7 @@ CONFIG_SPL_SPI=3Dy > CONFIG_SYS_LOAD_ADDR=3D0x800800 > CONFIG_DEBUG_UART=3Dy > CONFIG_BOOTSTAGE=3Dy > -CONFIG_SPL_BOOTSTAGE=3Dy > -CONFIG_TPL_BOOTSTAGE=3Dy > CONFIG_BOOTSTAGE_REPORT=3Dy > -CONFIG_SPL_BOOTSTAGE_RECORD_COUNT=3D10 > -CONFIG_BOOTSTAGE_STASH=3Dy > CONFIG_USE_PREBOOT=3Dy > CONFIG_DEFAULT_FDT_FILE=3D"rockchip/rk3399-rockpro64.dtb" > CONFIG_DISPLAY_BOARDINFO_LATE=3Dy > --=20 > 2.39.2.637.g21b0678d19-goog --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY/VTpgAKCRDcUY/If5cW qmU+AQCTMufaKWFF7NBPBwypG2wE6mF/rFDYuaoJrcqzu1+BCgD/atbgc6qv/AAu caDwG9Y3GpUxyt1gr1awlM4NF7MJBg8= =aLn0 -----END PGP SIGNATURE----- --=-=-=--