From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59B5BC05027 for ; Thu, 9 Feb 2023 14:08:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8406F85283; Thu, 9 Feb 2023 15:08:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="MH+DWLny"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D978485878; Thu, 9 Feb 2023 15:08:48 +0100 (CET) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE7448500E for ; Thu, 9 Feb 2023 15:08:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wr1-x429.google.com with SMTP id r2so1878869wrv.7 for ; Thu, 09 Feb 2023 06:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Yk89e4bI/O2CJ2rcaGrw2wEcx+HgrL7H2p1tvtNaXsM=; b=MH+DWLnys+nbamNXgzqg2KybQI3Uzg11silh6GwiflAD/Nf9hapEGOejHf33g2kPQi r81p2wSlXNKUA9qPgO+YdEP84Es6L4pH2FCI6TsmXdMwOS7zr9MFfdUomlc+NHOTt33s DXVlBGZqJeKVVGGVICK+zm6mFnae2dFic97ywL39XWvZ6zyqLY2s5HeUH9IzipztPnz9 NvLbkSPEYFzIfmd8c2LkQntYbMOsErkedyU36TM7FIhkyaGNtkUcSRrv/6BGNCZlkf5O NpPfGLo+m242dpCndEMZma94EFrALLd3s3nqbSQoUuwmOAGaIYQywyOD1PPbu2KVJNJx 4fHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yk89e4bI/O2CJ2rcaGrw2wEcx+HgrL7H2p1tvtNaXsM=; b=2aKaKLIY6KKILaja5m9lPyHq2S1DrtEdMoeee1KadyRRVRwyPTKWagYsdUuhUBU45M 37v2ihd4K8aDc8Uhun/1eRR9GJIilDLeKKmqMXuMvr1CMdrXH3uTdzZEb9tBejyXLYMR iUR6NqjGhwH4QDOfOS3UYPcwKwHEAV5/PbiTRUaCckPW/62QqqDzZIvr4tZTQFjtQG+5 4mI4GVGrl7P3dcZS5GtGNvpVZOCsdp/wcMZ3/IFiomi1OEfHTDdpi+0Cu56CmUjA5CZW p9F+AQN1lfCgPKTeKtQgAmouJok3T+wwbT3TkTxOSIZUYgEAc9kUsScChUOPJ18CoHiZ kG3w== X-Gm-Message-State: AO0yUKVxxOLTNYeDxZUWUGSMbbsjooyoIxO4c8tbkALi0WtfROrHE9xm J8PCNLq9J+BLKtQRJhaNGSJ1ZQ== X-Google-Smtp-Source: AK7set9RIViy1VsC/4QgTF3AfB7QG1i8PMGX8kj59wxw/qT4xe3zXSjPvPC0s6R8Ws5SqLYJECH93w== X-Received: by 2002:adf:db88:0:b0:2bf:e45d:8dff with SMTP id u8-20020adfdb88000000b002bfe45d8dffmr10665568wri.67.1675951725299; Thu, 09 Feb 2023 06:08:45 -0800 (PST) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id p11-20020adff20b000000b002c3f42f3687sm1375089wro.72.2023.02.09.06.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 06:08:44 -0800 (PST) From: Mattijs Korpershoek To: Safae Ouajih , sjg@chromium.org Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, glaroque@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v3 00/19] Support android boot image v3/v4 In-Reply-To: <20230205235021.355410-1-souajih@baylibre.com> References: <20230205235021.355410-1-souajih@baylibre.com> Date: Thu, 09 Feb 2023 15:08:26 +0100 Message-ID: <87cz6jj5id.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Feb 06, 2023 at 00:50, Safae Ouajih wrote: > Hello everyone, > > * This is based on Roman Stratiienko's work to support boot image header version 3 and 4. > > * This supports the new boot image headers v3, v4 and bootconfig feature. > https://source.android.com/docs/core/architecture/bootloader/boot-image-header > https://source.android.com/docs/core/architecture/bootloader/implementing-bootconfig > > - Tested on Amlogic Khadas vim3l, a reference board for Android Open Source Project > https://www.khadas.com/vim3l > > And on AM625 Texas Instruments board with 5.10 linux kernel > > Main changes : > - New partition : vendor boot, with a specific vendor ramdisk > - DTB is stored in the vendor boot partition > - The generic ramdisk is placed after the vendor ramdisk > - Bootconfig feature support > > > Here is a link to see the related android boot flow changes on KHADAS vim3l as an example: > https://gitlab.baylibre.com/baylibre/amlogic/atv/u-boot/-/commits/souajih/BootImagev4/ Re-tested the whole series on Khadas vim3l board with boot header v2. Tested-by: Mattijs Korpershoek > > Changes in v3: > - Ddd documentation for v3,v4 boot image header > - Add mkbootimg tool to Dockerfile > - Add full comments for functions/structs in include/image.h and include/android_image.h > - Add map_sysmem() to make the boot work on Sandbox > - Rename andr_vendor_img_hdr -> andr_vnd_boot_img_hdr > > Changes in v2: > - Rework parts of the code to fix the abootimg test: test_abootimg > - Update test_abootimg to support boot image header v4 > - Remove LIBXBC library, import and adapt the functions to support bootconfig feature > - Rename the used structures : > andr_boot_img_hdr_v0_v1_v2 -> andr_boot_img_hdr_v0 > andr_boot_img_hdr_v3_v4 -> andr_boot_img_hdr_v3 > andr_vendor_boot_img_hdr_v3_v4 -> andr_vendor_img_hdr > > Safae Ouajih (19): > android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0 > android: boot: support vendor boot image in abootimg > android: boot: replace android_image_check_header > android: boot: add boot image header v3 and v4 structures > android: boot: kcomp: support andr_image_data > android: boot: move to andr_image_data structure > android: boot: content print is not supported for v3,v4 header version > android: boot: boot image header v3,v4 do not support recovery DTBO > android: boot: add vendor boot image to prepare for v3,v4 support > android: boot: update android_image_get_data to support v3,v4 > android: boot: ramdisk: support vendor ramdisk > android: boot: support extra command line > android: boot: update android_image_get_dtb_img_addr to support v3,v4 > drivers: fastboot: zImage flashing is not supported for v3,v4 > android: boot: support boot image header version 3 and 4 > android: boot: support bootconfig > doc: android: add documentation for v3,v4 boot image header > test/py: android: extend abootimg test > Dockerfile: add mkbootimg tool > > boot/bootm.c | 37 +- > boot/image-android.c | 461 ++++++++++++++++---- > boot/image-board.c | 19 +- > boot/image-fdt.c | 5 +- > cmd/abootimg.c | 75 +++- > doc/android/boot-image.rst | 13 +- > drivers/fastboot/fb_mmc.c | 19 +- > include/android_image.h | 228 +++++++++- > include/image.h | 173 +++++++- > test/py/tests/test_android/test_abootimg.py | 136 +++++- > tools/docker/Dockerfile | 4 + > 11 files changed, 1009 insertions(+), 161 deletions(-) > > -- > 2.34.1