From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 964E7C433F5 for ; Tue, 11 Oct 2022 16:36:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D095184EFE; Tue, 11 Oct 2022 18:36:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="Sagql1DN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F2F784F0C; Tue, 11 Oct 2022 18:36:31 +0200 (CEST) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 64F0584D9F for ; Tue, 11 Oct 2022 18:36:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x32e.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so8503583wmq.1 for ; Tue, 11 Oct 2022 09:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6EEB/V6i4HKiu/O5BqmeU9FLC71YPS4wPERIIcoo7Zo=; b=Sagql1DNqHFy7BCeaGJxKVdDuD/KyojxccZz0u2j8utYlq0Km1u0WAwubkvNm3l72K gpvOC+ClVJLZZegjeoVkYLPWWTsmf14fjeRRczmR6TCwFoqVfpiBRwn04YXgIbvTukjA xQRFRdhV3QoRnHC2zYQYDXdUGoMfB9tyw6y2iHycNBJHXSoRhdWq26uiDBbW5ByQUEEe f5PSuNBm0m9YpZqO/sA2tkRBvRTiwxKHdaKAWingSvWosRxW+doZ/755YCmZgW+qVc5r VRgcq4xXORi6HToLsDBm2cB0QvtGSfftikNiTsdWbZMdNOTqdCiVQn62NRbP/9IZ9rfo +KXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6EEB/V6i4HKiu/O5BqmeU9FLC71YPS4wPERIIcoo7Zo=; b=z037mqt5PbxouRtNtEZ4ik9br/rWVYDaFtqeHjevXjigun7EhFlB5rBauiYtmQiUoi 4nXhWMZ1WMtJDYlm89fJ4fZKIvMEK1E5o6dRBvxUXp/jgeMkW/3cxL8zC0NeP9NwNW/W uNMhlY6dW/QIN4jCVDfnHQTK7f5VJDooRPLtbi8S/4ADFCjpsHppF8acdn3XOBSCZgGP tGJKT14hTpAEq3OUxE6xcfocBEINWbdZbEuBpBwVDlMu+f8IoPKbPCIzVxiTsSCqkth6 haXqiKv1LL9t0G4BIoLoFWKMwfhGc5LabpN67d4Z7LxKn71s8ewFl56Dgl3fYiNa1975 rfFw== X-Gm-Message-State: ACrzQf03XfdThoaBdeusECsMkv/iLoYkEiM3cGlhlFI8+ioN6Md+reVt JnsbsRyWe2frZJ7o4wUN7jK/Dw== X-Google-Smtp-Source: AMsMyM7Z1aerJpQlwtIWs7wE7pA/wkUb6KbaDK/yBjOtWA/UtYRBL0EyAzJbS/08z4iFbT+ojCk7qw== X-Received: by 2002:a05:600c:4fcb:b0:3b4:a4dd:615f with SMTP id o11-20020a05600c4fcb00b003b4a4dd615fmr17787801wmq.160.1665506187872; Tue, 11 Oct 2022 09:36:27 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id j10-20020a05600c190a00b003c6b7f5567csm4041009wmq.0.2022.10.11.09.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 09:36:27 -0700 (PDT) From: Mattijs Korpershoek To: Marek Vasut , neil.armstrong@linaro.org, Christian Hewitt , Lukasz Majewski Cc: u-boot@lists.denx.de, Simon Glass , u-boot-amlogic@groups.io Subject: Re: [PATCH v2 2/2] mach-meson: g12a: reset usb controller in reset_misc() In-Reply-To: <6b1237b8-746c-c9aa-4be4-ef323396b2f8@denx.de> References: <20220728-reset-usb-controller-v2-0-ef7657ce78b1@baylibre.com> <20220728-reset-usb-controller-v2-2-ef7657ce78b1@baylibre.com> <503f0753-e3be-6e86-5973-2843f5267f1c@denx.de> <8c083cfa-4d15-e71c-ba67-8077b282fd96@denx.de> <938b9439-9014-5ee8-1627-16af508bface@linaro.org> <6b1237b8-746c-c9aa-4be4-ef323396b2f8@denx.de> Date: Tue, 11 Oct 2022 18:36:26 +0200 Message-ID: <87czay2u7p.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 11, 2022 at 17:39, Marek Vasut wrote: > On 10/11/22 09:12, neil.armstrong@linaro.org wrote: >> On 10/10/2022 19:16, Marek Vasut wrote: >>> On 10/10/22 18:22, Neil Armstrong wrote: >>>> Hi, >>> >>> Hi, >>> >>>> On 10/10/2022 18:09, Marek Vasut wrote: >>>>> On 10/7/22 11:38, Mattijs Korpershoek wrote: >>>>>> On some g12a boards like the VIM3L and the SEI610, with some >>>>>> USB cables/hosts, there is a long (5s) delay before >>>>>> between "fastboot reboot" and the host detecting a USB reset. >>>>>> >>>>>> This breaks tools relying on "fastboot reboot fastboot" which assume >>>>>> that 1s after the command send, the board should disconnect on usb. >>>>>> >>>>>> To reproduce, enable fastboot in U-Boot console: >>>>>> =3D> fastboot usb 0 >>>>>> >>>>>> Then, on the host, run: >>>>>> =C2=A0=C2=A0 # echo "running fastboot reboot bootloader" > /dev/kmsg= &&=20 >>>>>> fastboot reboot bootloader >>>>>> =C2=A0=C2=A0 Rebooting into bootloader=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 OKAY [=C2=A0 0.003s] >>>>>> =C2=A0=C2=A0 Finished. Total time: 3.033s >>>>>> >>>>>> =C2=A0=C2=A0 [54074.251551] running fastboot reboot bootloader >>>>>> =C2=A0=C2=A0 ... there is a delay of 5s before we detect a disconnec= tion ... >>>>>> =C2=A0=C2=A0 [54079.041238] usb 1-7.4: USB disconnect, device number= 72 >>>>>> =C2=A0=C2=A0 [54079.239625] usb 1-7.4: new high-speed USB device num= ber 73=20 >>>>>> using xhci_hcd >>>>>> =C2=A0=C2=A0 [54079.359103] usb 1-7.4: New USB device found, idVendo= r=3D1b8e,=20 >>>>>> idProduct=3Dfada, bcdDevice=3D 2.27 >>>>>> =C2=A0=C2=A0 [54079.359110] usb 1-7.4: New USB device strings: Mfr= =3D1,=20 >>>>>> Product=3D2, SerialNumber=3D3 >>>>>> =C2=A0=C2=A0 [54079.359112] usb 1-7.4: Product: USB download gadget >>>>>> =C2=A0=C2=A0 [54079.359114] usb 1-7.4: Manufacturer: U-Boot >>>>>> =C2=A0=C2=A0 [54079.359116] usb 1-7.4: SerialNumber: C8631470CC41 >>>>>> >>>>>> Note: this does not happen when we use the RST button on the board. >>>>>> >>>>>> To fix this, re-implement a platform reset which calls >>>>>> board_usb_cleanup() before resetting the board. >>>>> >>>>> Shouldn't that call happen somewhere in drivers/usb/ .remove()=20 >>>>> callback instead ? >>>> >>>> No since dwc2 isn't DM yet, handling is done in arch/arm/mac-meson=20 >>>> board_usb_*() for now >>> >>> Seems DWC2 is DM: >>> >>> $ git grep U_BOOT_DRIVER drivers/usb/ | grep dwc2 >>> drivers/usb/gadget/dwc2_udc_otg.c:U_BOOT_DRIVER(dwc2_udc_otg) =3D { >>> drivers/usb/host/dwc2.c:U_BOOT_DRIVER(usb_dwc2) =3D { >>> >>=20 >> My bad, seems I missed the dwc2 otg DM wagon... >>=20 >> We will need to switch to this now then, thanks, > > Thanks. I picked 1/2 at least, so you can only focus on 2/2 and send=20 > just that. Yes, thank you for picking 1/2 Neil, do you want me to look into converting the meson arch which uses DWC2 to DM? I'm not sure I'm confident to do these changes properly but I'm willing to give it a try. If you plan to do it yourself, fine by me. I'll respin 2/2 after that.