[U-Boot] [PATCH] Revert "fdt: Fix FIT header verification in mkimage and conduct same checks as bootm"

[Vagrant Cascadian <vagrant@debian.org>]

FTR, using updated email addresses for agraf and sjg.

On 2019-04-09, Jordan Hand wrote:
> On Mon, Apr 8, 2019 at 9:54 PM Vagrant Cascadian <vagrant@debian.org> wrote:
>>
>> This reverts commit d32aa3cae44e618048ff7f378577d44f9b6d6dcc.
>>
>> This breaks the "list_image" test in tests/image/test-imagetools.sh,
>> where mkimage and dumpimage are expected to have the same output:
>>
>>   Listing image contents...
>>   # debian/build/tools/tools/mkimage -l linux.itb
>>   debian/build/tools/tools/mkimage: verify_header failed for Default Image support with exit code -9
>>
>> Obviously, blindly reverting this patch may not the best way forward,
>
> I'll take a look at this today and see if there's a simple way forward
> without reverting

Thanks!


>> but the same verify_header failed message occurs also with some
>> real-world .itb files, such as that used on the pinebook. So it's not
>
> Would you be able to point me to any .its files that fail this check
> in the real world.

The one created by: board/sunxi/mksunxi_fit_atf.sh

I haven't confirmed, but I would guess possibly also:
arch/arm/mach-rockchip/make_fit_atf.py

If needed, I can try to get some actual .its/.itb files to work with.


> Also are you seeing failures while creating the image from its as well
> with real world images (mkimage -l its itb) or only when listing the
> header with -l?

It *seems* to create the images just fine; apparently only when listing
them. The output of "dumpimage -l" and "mkimage -l" used to be the same,
and "dumpimage -l" still works fine.


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190409/2f93d3fe/attachment.sig>