Re: [PATCH v5 68/75] usb: dwc3: make gadget and ep0 build in u-boot

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Anders,

Thank you for the patch.

On Thu, Jul 16, 2026 at 15:42, Anders Roxell <anders.roxell@linaro.org> wrote:

> Adapt the DWC3 gadget and ep0 code to u-boot after the resync.

Similarly to the previous patch, I see some functions that are moved
around in the gadget.c file, making the diff bigger than it should be.

Please re-arrange things to keep the diff at a minimum so that review is
a bit easier.

I've not done a thorough pass on this one because of the above.

Thanks
Mattijs

>
> Co-developed-by: Jerome Forissier <jerome.forissier@linaro.org>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> Co-developed-by: Jens Wiklander <jens.wiklander@linaro.org>
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  drivers/usb/dwc3/ep0.c    | 110 +++---
>  drivers/usb/dwc3/gadget.c | 786 ++++++++------------------------------
>  drivers/usb/dwc3/gadget.h |   4 +-
>  3 files changed, 207 insertions(+), 693 deletions(-)
>
> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
> index 666ac432f52d..0a4f69cbc28a 100644
> --- a/drivers/usb/dwc3/ep0.c
> +++ b/drivers/usb/dwc3/ep0.c
> @@ -1,4 +1,3 @@
> -// SPDX-License-Identifier: GPL-2.0

Why the licence drop?

>  /*

[...]