From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>,
Lukasz Majewski <lukma@denx.de>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
u-boot@lists.denx.de
Cc: Sean Anderson <sean.anderson@linux.dev>
Subject: Re: [PATCH] dfu: Report error codes
Date: Wed, 14 Jan 2026 12:20:27 +0100 [thread overview]
Message-ID: <87ecnsfnk4.fsf@kernel.org> (raw)
In-Reply-To: <20260106222212.744823-1-sean.anderson@linux.dev>
Hi Sean,
Thank you for the patch.
On Tue, Jan 06, 2026 at 17:22, Sean Anderson <sean.anderson@linux.dev> wrote:
> A lot of things can go wrong while parsing dfu_alt_info. Make sure to
> pass the real error codes all the way up instead of replacing them with
> an unhelpful -1.
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
This is a nice improvement! I'm happy to pick this up.
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
>
> drivers/dfu/dfu.c | 52 ++++++++++++++++++++++++++---------------------
> 1 file changed, 29 insertions(+), 23 deletions(-)
>
next prev parent reply other threads:[~2026-01-14 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 22:22 [PATCH] dfu: Report error codes Sean Anderson
2026-01-14 11:20 ` Mattijs Korpershoek [this message]
2026-01-15 8:25 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecnsfnk4.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=lukma@denx.de \
--cc=sean.anderson@linux.dev \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox