From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Andrew Goodbody <andrew.goodbody@linaro.org>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2] cmd: abootimg: Prevent use of unintialised variable
Date: Fri, 27 Jun 2025 08:43:45 +0200 [thread overview]
Message-ID: <87ecv5y99a.fsf@kernel.org> (raw)
In-Reply-To: <c5a4f007-0846-42a8-a153-d95cb070dc66@linaro.org>
On Wed, Jun 25, 2025 at 17:31, Andrew Goodbody <andrew.goodbody@linaro.org> wrote:
> On 25/06/2025 17:10, Mattijs Korpershoek wrote:
[...]
>
>> android_image_get_data() handles the case where vendor_boot_hdr is NULL:
>> """
>> if (((struct andr_boot_img_hdr_v0 *)boot_hdr)->header_version > 2) {
>> if (!vendor_boot_hdr) {
>> printf("For boot header v3+ vendor boot image has to be provided\n");
>> return false;
>> }
>> """
>>
>> So I don't think we should early return here.
>> If we do, we will probably break boot image v2 support.
>
> Well I guess the alternate fix is to just init vhdr to be NULL?
Yes, that would be better.
>
> Andrew
>
>>>
[...]
prev parent reply other threads:[~2025-06-27 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 15:52 [PATCH v2] cmd: abootimg: Prevent use of unintialised variable Andrew Goodbody
2025-06-25 15:57 ` Tom Rini
2025-06-25 16:10 ` Mattijs Korpershoek
2025-06-25 16:31 ` Andrew Goodbody
2025-06-27 6:43 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecv5y99a.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=andrew.goodbody@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox