U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marek Vasut <marex@denx.de>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] eth: asix88179: reset during probe
Date: Tue, 09 Jul 2024 14:25:49 +0200	[thread overview]
Message-ID: <87ed82iwfm.fsf@baylibre.com> (raw)
In-Reply-To: <d8943137-1748-4f57-8a85-0561d2af05d4@denx.de>

Hi Marek,

On mar., juil. 09, 2024 at 13:13, Marek Vasut <marex@denx.de> wrote:

> On 7/9/24 10:39 AM, Mattijs Korpershoek wrote:
>> Hi Caleb,
>
> Hi,
>
>> Thank you for the patch.
>> 
>> On mar., juin 18, 2024 at 16:57, Caleb Connolly <caleb.connolly@linaro.org> wrote:
>> 
>>> In some cases (consistently in my case with an embedded board) the
>>> ethernet controller will time out on the first init but always succeed
>>> after reset.
>>>
>>> Let's reset the controller during probe so we always start with it in a
>>> known state, and don't have wait for the first asix_wait_link() to
>>> time out.
>>>
>>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>> 
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>> 
>>> ---
>>> I see this behaviour consistently across three Qualcomm platforms that use this
>>> controller.
>>> ---
>>>   drivers/usb/eth/asix88179.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>
> Do you want to pick it via usb-gadget tree or shall I pick it via usb tree ?

According to get_maintainer.pl, it should be you :)

./scripts/get_maintainer.pl -- drivers/usb/eth/asix88179.c
Marek Vasut <marex@denx.de> (maintainer:USB)
Tom Rini <trini@konsulko.com> (maintainer:THE REST,authored:3/3=100%,added_lines:1/1=100%,removed_lines:2/2=100%)
Mattijs Korpershoek <mkorpershoek@baylibre.com> (commit_signer:1/3=33%)
u-boot@lists.denx.de (open list)

If you are okay with that, please pick it up.

Thanks!
Mattijs

  reply	other threads:[~2024-07-09 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 14:57 [PATCH] eth: asix88179: reset during probe Caleb Connolly
2024-06-23  4:34 ` Marek Vasut
2024-07-09  8:39 ` Mattijs Korpershoek
2024-07-09 11:13   ` Marek Vasut
2024-07-09 12:25     ` Mattijs Korpershoek [this message]
2024-07-13 17:52       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed82iwfm.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=caleb.connolly@linaro.org \
    --cc=marex@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox