Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

Dragan Simic
2024-02-09T19:38:05Z

On 2024-02-09 20:20, Igor Opaniuk wrote:
> From: Igor Opaniuk <igor.opaniuk@gmail.com>
>
> mmc_switch_part() is used for switching between hw partitions
> on eMMC (boot0, boot1, user, rpmb).
> There is no need to do that for SD card.
>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>

Looking good to me.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
>
> Changes in v2:
> - Mattijs Korpershoek R-b tag applied
>
> common/avb_verify.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index 48ba8db51e5..59f2c25e0de 100644
> --- a/common/avb_verify.c
> +++ b/common/avb_verify.c
> @@ -358,9 +358,11 @@ static struct mmc_part *get_partition(AvbOps
> *ops, const char *partition)
> goto err;
> }
>
> - ret = mmc_switch_part(part->mmc, part_num);
> - if (ret)
> - goto err;
> + if (IS_MMC(part->mmc)) {
> + ret = mmc_switch_part(part->mmc, part_num);
> + if (ret)
> + goto err;
> + }
>
> mmc_blk = mmc_get_blk_desc(part->mmc);
> if (!mmc_blk) {