From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B182C636CC for ; Tue, 31 Jan 2023 16:58:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0AC3985B61; Tue, 31 Jan 2023 17:58:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="H+Y38Avp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3556C85B13; Tue, 31 Jan 2023 17:58:20 +0100 (CET) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F4D085B61 for ; Tue, 31 Jan 2023 17:58:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x32a.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso8302330wms.4 for ; Tue, 31 Jan 2023 08:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Bllb42/yGfUzJAfQ5Pu5Uj1vsxO4O+9hcWKy+soBhHo=; b=H+Y38AvpbM3/7G/dO7D+JzaUGa0izuwcwbLsWdTGshBM0I6RO/+ApLdVdcBY2+NtQN RvOhWw+t8Wp6T+NJq6zVPr/ThlHnq6kPk4gIgH0BYYFi1X3Wk8sMy2XTHoBGn9IIm3JS Igiu9vQHcw23ms011D4WYhfHfyH6ojCwGIN4kHzuk6VA7BIaE5ECZT1oXMf+3moo5j9Y 6iYZR/XIA6b1WVkD7AFa8Wld6eSuBXehD0Zmj7Q9i2AqC/Hk0ucSgY7iGUAo4mqvfo7g 1sBMJT4FNaeq9cO6k3J29LFVHp2TNU4HLZYCkHyuuAINSwiUbN/9VNbGypAaSlJSXomC DIOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bllb42/yGfUzJAfQ5Pu5Uj1vsxO4O+9hcWKy+soBhHo=; b=02O5l9wuut0Wsn7PcJ+9UUBcwBhiWmR1qzarIezIIjdwjA/UDM86mPqE7k9oke3YXo a7L7t8i9u7Ggun3aKXQxdcBZFRZ6D/8nQWi3C+/NaoGuOOJSxnJwr0xuRMdiWpk7uZXo SsZ8PfSJROdcPE3FPned4zzg6/a0X5oH8Mo0SrZroRPWFblx4SK08zw/qemEEERKuoXz nVALn+fNsC2TqNQn5jhJtJNGW6FGt2bZr+kMeZyN75Jk4XmSLXlLXREQJ87MeraMj1UI ysf+Vq5ih8Fb8CQTYOrHfVCZr2NIdhwLckwdahojC618zrW0FqgW9CFrJvk4/a7p2bZg IdAA== X-Gm-Message-State: AO0yUKU74jNz7acqNUEwSD6MKSgBdyi9uv4S2xVai+BBNvaGkzTFgbfA PvuNTTCcFTJl7LGJ3Nig3x4UmX85u1oJtfa+ X-Google-Smtp-Source: AK7set8j0h9HHLvxjZjd0i96GIPBadCXDRIuYRPK1f2HvunG4L6fzEbwEB2ovQOy8O/YnMl7783RqQ== X-Received: by 2002:a05:600c:1d02:b0:3dc:5ad0:e583 with SMTP id l2-20020a05600c1d0200b003dc5ad0e583mr7530861wms.22.1675184295915; Tue, 31 Jan 2023 08:58:15 -0800 (PST) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id p6-20020a5d48c6000000b002bfc0558ecdsm14999673wrs.113.2023.01.31.08.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 08:58:15 -0800 (PST) From: Mattijs Korpershoek To: Simon Glass , U-Boot Mailing List Cc: Tom Rini , Simon Glass , Heiko Schocher , Patrick Delaunay , Sean Anderson Subject: Re: [PATCH 088/171] Correct SPL uses of FASTBOOT_FLASH_NAND In-Reply-To: <20230130144324.206208-89-sjg@chromium.org> References: <20230130144324.206208-1-sjg@chromium.org> <20230130144324.206208-89-sjg@chromium.org> Date: Tue, 31 Jan 2023 17:58:14 +0100 Message-ID: <87edrak5eh.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Jan 30, 2023 at 07:42, Simon Glass wrote: > This converts 3 usages of this option to the non-SPL form, since there is > no SPL_FASTBOOT_FLASH_NAND defined in Kconfig > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > drivers/fastboot/fb_command.c | 4 ++-- > drivers/fastboot/fb_getvar.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c > index 5a3fb69b3f7..71cfaec6e9d 100644 > --- a/drivers/fastboot/fb_command.c > +++ b/drivers/fastboot/fb_command.c > @@ -299,7 +299,7 @@ static void __maybe_unused flash(char *cmd_parameter, char *response) > fastboot_mmc_flash_write(cmd_parameter, fastboot_buf_addr, > image_size, response); > > - if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_NAND)) > + if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_NAND)) > fastboot_nand_flash_write(cmd_parameter, fastboot_buf_addr, > image_size, response); > } > @@ -318,7 +318,7 @@ static void __maybe_unused erase(char *cmd_parameter, char *response) > if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_MMC)) > fastboot_mmc_erase(cmd_parameter, response); > > - if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_NAND)) > + if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_NAND)) > fastboot_nand_erase(cmd_parameter, response); > } > > diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c > index de4879dadfb..dd3475e0a8b 100644 > --- a/drivers/fastboot/fb_getvar.c > +++ b/drivers/fastboot/fb_getvar.c > @@ -104,7 +104,7 @@ static int getvar_get_part_info(const char *part_name, char *response, > response); > if (r >= 0 && size) > *size = disk_part.size * disk_part.blksz; > - } else if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_NAND)) { > + } else if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_NAND)) { > r = fastboot_nand_get_part_info(part_name, &part_info, response); > if (r >= 0 && size) > *size = part_info->size; > -- > 2.39.1.456.gfc5497dd1b-goog