From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] dm: video: bridge: don't fail to activate bridge if sleep gpio is missing
Date: Sun, 30 Sep 2018 10:48:20 -0700 [thread overview]
Message-ID: <87efdaq3kr.fsf@aikidev.net> (raw)
In-Reply-To: <CA+E=qVcfO9jyWoXQ0L=pfo9Q7V6NsX_xUgSoZYrNn7Tvw0LF7Q@mail.gmail.com>
On 2018-09-29, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> On Sat, Sep 29, 2018 at 4:46 PM Vagrant Cascadian <vagrant@debian.org> wrote:
>> Sleep gpio is optional, so it's possible to have reset gpio, but no sleep gpio.
>> We shouldn't fail early in case of missing sleep gpio, otherwise we won't
>> deassert reset.
...
>> diff --git a/drivers/video/bridge/video-bridge-uclass.c b/drivers/video/bridge/video-bridge-uclass.c
>> index cd4959cc71..46936a0626 100644
>> --- a/drivers/video/bridge/video-bridge-uclass.c
>> +++ b/drivers/video/bridge/video-bridge-uclass.c
>> @@ -110,7 +110,7 @@ int video_bridge_set_active(struct udevice *dev, bool active)
>>
>> debug("%s: %d\n", __func__, active);
>> ret = dm_gpio_set_value(&uc_priv->sleep, !active);
>> - if (ret)
>> + if (ret != -ENOENT)
>
> It should be 'if (ret && ret != -ENOENT)'. Btw, I fixed it in
> pinebook-wip-20180909 branch.
That's where I pulled the patch from; it's present in the patch to
anx6345.c, but apparently unpatched in this patch against
video-bridge-uclass.c.
I'll submit the fixed version in a new patch series after collecting
more comments...
Thanks for all your work on it!
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180930/a5659602/attachment.sig>
next prev parent reply other threads:[~2018-09-30 17:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 23:45 [U-Boot] [PATCH 0/5] Vagrant Cascadian
2018-09-29 23:45 ` [U-Boot] [PATCH 1/5] mmc: sunxi: add support for automatic delay calibration Vagrant Cascadian
2018-09-30 15:16 ` André Przywara
2018-10-01 8:09 ` Maxime Ripard
2018-10-01 8:48 ` Andre Przywara
2018-10-01 10:01 ` Maxime Ripard
2018-09-29 23:45 ` [U-Boot] [PATCH 2/5] dm: video: bridge: don't fail to activate bridge if sleep gpio is missing Vagrant Cascadian
2018-09-30 6:02 ` Vasily Khoruzhick
2018-09-30 17:48 ` Vagrant Cascadian [this message]
2018-09-30 20:15 ` Vasily Khoruzhick
2018-09-30 22:13 ` André Przywara
2018-09-29 23:45 ` [U-Boot] [PATCH 3/5] video: anx6345: don't fail if there's no sleep or reset GPIOs Vagrant Cascadian
2018-09-30 22:26 ` André Przywara
2018-09-29 23:45 ` [U-Boot] [PATCH 4/5] sun50i: a64: add support for R_I2C controller Vagrant Cascadian
2018-10-01 8:11 ` Maxime Ripard
2018-09-29 23:45 ` [U-Boot] [PATCH 5/5] sunxi: add support for Pinebook Vagrant Cascadian
2018-10-01 8:17 ` Maxime Ripard
2018-10-01 9:37 ` Icenowy Zheng
2018-10-01 10:00 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efdaq3kr.fsf@aikidev.net \
--to=vagrant@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox