From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vagrant Cascadian Date: Sun, 30 Sep 2018 10:48:20 -0700 Subject: [U-Boot] [PATCH 2/5] dm: video: bridge: don't fail to activate bridge if sleep gpio is missing In-Reply-To: References: <20180929234553.31019-1-vagrant@debian.org> <20180929234553.31019-3-vagrant@debian.org> Message-ID: <87efdaq3kr.fsf@aikidev.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2018-09-29, Vasily Khoruzhick wrote: > On Sat, Sep 29, 2018 at 4:46 PM Vagrant Cascadian wrote: >> Sleep gpio is optional, so it's possible to have reset gpio, but no sleep gpio. >> We shouldn't fail early in case of missing sleep gpio, otherwise we won't >> deassert reset. ... >> diff --git a/drivers/video/bridge/video-bridge-uclass.c b/drivers/video/bridge/video-bridge-uclass.c >> index cd4959cc71..46936a0626 100644 >> --- a/drivers/video/bridge/video-bridge-uclass.c >> +++ b/drivers/video/bridge/video-bridge-uclass.c >> @@ -110,7 +110,7 @@ int video_bridge_set_active(struct udevice *dev, bool active) >> >> debug("%s: %d\n", __func__, active); >> ret = dm_gpio_set_value(&uc_priv->sleep, !active); >> - if (ret) >> + if (ret != -ENOENT) > > It should be 'if (ret && ret != -ENOENT)'. Btw, I fixed it in > pinebook-wip-20180909 branch. That's where I pulled the patch from; it's present in the patch to anx6345.c, but apparently unpatched in this patch against video-bridge-uclass.c. I'll submit the fixed version in a new patch series after collecting more comments... Thanks for all your work on it! live well, vagrant -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 227 bytes Desc: not available URL: