public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h.
Date: Thu, 12 Nov 2015 11:39:07 -0600	[thread overview]
Message-ID: <87egfvdsn8.fsf@aikidev.net> (raw)
In-Reply-To: <5644C951.4080208@denx.de>

On 2015-11-12, Stefano Babic wrote:
> On 27/10/2015 21:18, Vagrant Cascadian wrote:
>> This allows for more flexible and standardized boot across multiple
>> platforms.
>> 
>> Remove redundant legacy boot environment.
>> 
>
> I have applied it.

Thanks!


> However, the patch generates a warning due to
> CONFIG_BOOT_DELAY, that is defined twice. Firstly, it is defined in
> mx6_common.h (anyway, in this file is protected) and then in distro_default

Oops, forgot to file an updated patch to fix that...


>> +#define BOOT_TARGET_DEVICES(func) \
>> +	func(MMC, mmc, 0) \
>> +	func(USB, usb, 0) \
>> +	func(PXE, pxe, na) \
>> +	func(DHCP, dhcp, na)
>> +
>
>> +#include <config_distro_defaults.h>
>> +#include <config_distro_bootcmd.h>
>
> Maybe just  #undef CONFIG_BOOT_DELAY before including distro files ?

Alternately, including config_distro_defaults.h could be moved before
including mx6_common.h. Either way works fine by me.

Same applies for the wandboard patch.

I just realized that the console setting for mx6cuboxi should also
include the baudrate, just like for the wandboard.


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151112/b04e2616/attachment.sig>

      reply	other threads:[~2015-11-12 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 20:18 [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h Vagrant Cascadian
2015-11-12 16:24 ` Stefano Babic
2015-11-12 17:16 ` Stefano Babic
2015-11-12 17:39   ` Vagrant Cascadian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egfvdsn8.fsf@aikidev.net \
    --to=vagrant@debian.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox