From: Peter Korsgaard <jacmet@sunsite.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Initialise correct GPMC WAITx irq for AM33xx
Date: Thu, 21 Feb 2013 14:04:29 +0100 [thread overview]
Message-ID: <87ehg9hl7m.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <512617E2.9020404@mimc.co.uk> (Mark Jackson's message of "Thu, 21 Feb 2013 12:49:38 +0000")
>>>>> "Mark" == Mark Jackson <mpfj-list@mimc.co.uk> writes:
Mark> Currently WAIT0 irq is reset and then WAIT1 irq is enabled.
Mark> Fix it such that WAIT0 irq is enabled instead.
Mark> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
Mark> ---
Mark> arch/arm/cpu/armv7/am33xx/mem.c | 2 +-
Mark> 1 file changed, 1 insertion(+), 1 deletion(-)
Mark> diff --git a/arch/arm/cpu/armv7/am33xx/mem.c b/arch/arm/cpu/armv7/am33xx/mem.c
Mark> index b8f54ab..b86b0de 100644
Mark> --- a/arch/arm/cpu/armv7/am33xx/mem.c
Mark> +++ b/arch/arm/cpu/armv7/am33xx/mem.c
Mark> @@ -83,7 +83,7 @@ void gpmc_init(void)
Mark> /* global settings */
Mark> writel(0x00000008, &gpmc_cfg->sysconfig);
Mark> writel(0x00000100, &gpmc_cfg->irqstatus);
Mark> - writel(0x00000200, &gpmc_cfg->irqenable);
Mark> + writel(0x00000100, &gpmc_cfg->irqenable);
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Why do we even enable the irq in the first place? The gpmc driver just
polls irqstatus anyway.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-02-21 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 12:49 [U-Boot] [PATCH] Initialise correct GPMC WAITx irq for AM33xx Mark Jackson
2013-02-21 13:04 ` Peter Korsgaard [this message]
2013-03-26 14:51 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehg9hl7m.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox