Re: [PATCH v2 01/11] test: Create a common file for image utilities

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Simon,

Thank you for the patch.

On Sat, May 23, 2026 at 02:54, Simon Glass <sjg@chromium.org> wrote:

> Move mkdir_cond(), copy_partition(), and make_extlinux_disk() to a
> common module which can be used by the rest of the image-creation code.
>
> Add myself as a maintainer for this new directory, and the test/py
> framework itself.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Rename the setup_extlinux_image() helper to make_extlinux_disk()
>
>  MAINTAINERS              |  5 +++
>  test/py/img/common.py    | 86 ++++++++++++++++++++++++++++++++++++++++
>  test/py/tests/test_ut.py | 77 ++---------------------------------
>  3 files changed, 94 insertions(+), 74 deletions(-)
>  create mode 100644 test/py/img/common.py
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0dcc7243124..d33ea42116c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1829,6 +1829,11 @@ M:	Liviu Dudau <liviu.dudau@foss.arm.com>
>  S:	Maintained
>  F:	drivers/video/tda19988.c
>  
> +TEST FRAMEWORK (PYTHON)
> +M:	Simon Glass <sjg@chromium.org>

Add a S: line here as well, otherwise get_maintainers.pl reports this as
"unknown"

$ ./scripts/get_maintainer.pl -f test/py
Simon Glass <sjg@chromium.org> (unknown:TEST FRAMEWORK (PYTHON),commit_signer:51/90=57%,authored:42/90=47%)

When S: line is present:
$ ./scripts/get_maintainer.pl -f test/py
Simon Glass <sjg@chromium.org> (maintainer:TEST FRAMEWORK (PYTHON),commit_signer:51/90=57%,authored:42/90=47%)

With the above change:
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> +F:	test/py
> +F:	test/py/img
> +
>  TI LP5562 LED DRIVER
>  M:	Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>  S:	Supported
> diff --git a/test/py/img/common.py b/test/py/img/common.py
> new file mode 100644
> index 00000000000..301b6c840d4
> --- /dev/null
> +++ b/test/py/img/common.py
> @@ -0,0 +1,86 @@