U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marek Vasut <marex@denx.de>, Zixun LI <admin@hifiphile.com>
Cc: Lukasz Majewski <lukma@denx.de>, Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support
Date: Fri, 26 Jul 2024 11:34:31 +0200	[thread overview]
Message-ID: <87frrw4hug.fsf@baylibre.com> (raw)
In-Reply-To: <24112707-c09b-4600-9e7a-a3d071e87952@denx.de>

Hi,

On jeu., juil. 25, 2024 at 20:57, Marek Vasut <marex@denx.de> wrote:

> On 7/25/24 8:48 PM, Zixun LI wrote:
>> On Thu, Jul 25, 2024 at 8:24 PM Marek Vasut <marex@denx.de> wrote:
>>>
>>> On 7/25/24 5:31 PM, Zixun LI wrote:
>>>> Changes in v4:
>>>> - Release clocks if probe failed
>>>> - Add missing endpoint data free
>>>> - Addressed comments
>>>
>>> Please collect any AB/RB/TB tags that were provided in v3 too.
>>
>> Sorry didn't know that, should I spin a v5 ?
>
> No worries, wait a few days for more feedback (if any), and then collect
> them for V5 and send V5.

Indeed, it's important to collect the tags to make sure that the
reviewers get credit for their time reviewing.

Zixun, make sure to collect them for all future contributions.

Fortunately, b4 (https://b4.docs.kernel.org/en/latest/index.html) can
collect the tags:

$ b4 shazam -s -l --check 20240725153204.358925-1-admin@hifiphile.com

[...]

  ✓ [PATCH v4 1/7] usb: gadget: atmel: Sort includes
    + Reviewed-by: Marek Vasut <marex@denx.de> (✓ DKIM/denx.de)
    + Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> (✓ DKIM/baylibre-com.20230601.gappssmtp.com)
    + Link: https://lore.kernel.org/r/20240725153204.358925-2-admin@hifiphile.com
    + Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
    ● checkpatch.pl: passed all checks

So, for this series, 2 cases can happen:

1. No other review comments are found. A v5 won't be required.
   I will collect the tags with b4 when applying to the u-boot-dfu tree

2. New review comments require the series to be modified. A v5 is
   required. In that case, make sure to collect all tags yourself.

Please wait a few days for others to get time to chime in this patch
series.

Thank you for your contribution !

Mattijs

  reply	other threads:[~2024-07-26  9:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 15:31 [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support Zixun LI
2024-07-25 15:31 ` [PATCH v4 1/7] usb: gadget: atmel: Sort includes Zixun LI
2024-07-25 15:31 ` [PATCH v4 2/7] usb: gadget: atmel: Replace printf() and pr_err() by log_err() Zixun LI
2024-07-25 15:31 ` [PATCH v4 3/7] usb: gadget: atmel: Fix typo in usb gadget driver register and unregister Zixun LI
2024-07-25 15:31 ` [PATCH v4 4/7] usb: gadget: atmel: Move usba_udc_pdata() with other static functions Zixun LI
2024-07-25 15:31 ` [PATCH v4 5/7] usb: gadget: atmel: Rename atmel_usba_start()/_stop() to usba_udc_enable()/_disable() Zixun LI
2024-07-25 15:32 ` [PATCH v4 6/7] usb: gadget: atmel: Add attach/detach support Zixun LI
2024-07-25 15:32 ` [PATCH v4 7/7] usb: gadget: atmel: Add DM_USB_GADGET support Zixun LI
2024-07-30  9:13   ` Mattijs Korpershoek
2024-07-25 18:24 ` [PATCH v4 0/7] usb: gadget: atmel: Code refactor and " Marek Vasut
2024-07-25 18:48   ` Zixun LI
2024-07-25 18:57     ` Marek Vasut
2024-07-26  9:34       ` Mattijs Korpershoek [this message]
2024-08-06 12:59 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frrw4hug.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=admin@hifiphile.com \
    --cc=lukma@denx.de \
    --cc=marex@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox