From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9FF4C61DA4 for ; Wed, 22 Feb 2023 13:17:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2FF2085AC2; Wed, 22 Feb 2023 14:17:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="tIBBwYj9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ABBA985ABF; Wed, 22 Feb 2023 14:17:33 +0100 (CET) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5501F85A86 for ; Wed, 22 Feb 2023 14:17:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x330.google.com with SMTP id o4-20020a05600c4fc400b003e1f5f2a29cso6303390wmq.4 for ; Wed, 22 Feb 2023 05:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=d4NY2tv7saKyWuc+yjjLcNjak8HsySeRjgeHV7D/I4s=; b=tIBBwYj9tS7Wgk5oMh+V3veFOs+gXL+v3FVcyyfBKT43OnOY9w17f8nYtlPnjTpWn2 1IzEcdS+qcqthDPO8D8+Ku+j+zxyT8fxmD7oRaufhtsvtuTLgbjf7v9i9ndsRx38sa/c 37TmA4Tl+sTBiEydRq1ApOyehzXw3X0RIhVx4h/sJ3JgmyW5oHivf5FV5WK8npkjaA8s FiEuVLfAAz1pqjH/3JONDCzEFR/zP8BloK4gEb3+BmCJtJhZM6j7ZHV8AJEpd6W4WGV7 oTD6EPmoW9TQDqjYl/MaLzm8AqtYTrpGyMD0rKFCk6nyXOOPJeQHlG5XrmOblxWbQ3OD 4qqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d4NY2tv7saKyWuc+yjjLcNjak8HsySeRjgeHV7D/I4s=; b=K4pBA71OTvl2rUWpPrag4+0hQC7vvbhobrqOz3mMzVsKSelZsrKpkXfucrzbCpPJ5k Yi2hpstcECqwmchXko/Af+XSMj3zFC5flpbLh2WVZDvNhrZVLXOZ/TVLlB68Kyd2+dZ6 MqFd1jPmPJggtK+zfBh2lsZq7hBZdW3b9wyFZ3msxKElP+7x819kpGy4Zd1oTskCSzXN rl1CPdCpG0bvwvsnWTP05rqT3tMBdRhATPQLC+8rI5c05zM5VKjyRXzFNYh5jq9rFLHJ nppYElYSMY4iS9GymCGFddjXey1a3hFpGBoGuiZkNGt/hnR7w4iJc6US8kb2vAVHvLJh s2Tw== X-Gm-Message-State: AO0yUKUVl/G8aBxtAwJidj5KuA67+s7FVJd1ZQUFq5evhXBOmop6GKmV YrQ+sFcyGRkWGW3sJxPVNRJ95w== X-Google-Smtp-Source: AK7set9CUp3Hoh8DdWEEHquOzwK3bMoVDdrtX3YwEIV1vPjHhArqKr3M57EQdp2MicTd+ox83Mw+6Q== X-Received: by 2002:a05:600c:2e94:b0:3e0:6c4:6a38 with SMTP id p20-20020a05600c2e9400b003e006c46a38mr318374wmn.33.1677071850709; Wed, 22 Feb 2023 05:17:30 -0800 (PST) Received: from localhost ([2a01:cb19:85e6:1900:2bf7:7388:731d:c4e1]) by smtp.gmail.com with ESMTPSA id m3-20020a05600c4f4300b003df5be8987esm557384wmq.20.2023.02.22.05.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 05:17:30 -0800 (PST) From: Mattijs Korpershoek To: Samuel Holland , u-boot@lists.denx.de Cc: Samuel Holland , Patrick Delaunay , Sean Anderson , Simon Glass Subject: Re: [PATCH] fastboot: Only call the bootm command if it is enabled In-Reply-To: <20230220061458.43549-1-samuel@sholland.org> References: <20230220061458.43549-1-samuel@sholland.org> Date: Wed, 22 Feb 2023 14:17:29 +0100 Message-ID: <87fsax4z6e.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On lun., f=C3=A9vr. 20, 2023 at 00:14, Samuel Holland = wrote: > This fixes an error with trying to link against do_bootm() when > CONFIG_CMD_BOOTM is disabled. > > Signed-off-by: Samuel Holland Reviewed-by: Mattijs Korpershoek > --- > > drivers/fastboot/fb_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c > index 57b6182c46a..20aa80838ae 100644 > --- a/drivers/fastboot/fb_common.c > +++ b/drivers/fastboot/fb_common.c > @@ -135,7 +135,7 @@ void fastboot_boot(void) > s =3D env_get("fastboot_bootcmd"); > if (s) { > run_command(s, CMD_FLAG_ENV); > - } else { > + } else if (IS_ENABLED(CONFIG_CMD_BOOTM)) { > static char boot_addr_start[20]; > static char *const bootm_args[] =3D { > "bootm", boot_addr_start, NULL > --=20 > 2.39.2