* [PATCH] fastboot: Only call the bootm command if it is enabled
@ 2023-02-20 6:14 Samuel Holland
2023-02-22 13:17 ` Mattijs Korpershoek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Samuel Holland @ 2023-02-20 6:14 UTC (permalink / raw)
To: u-boot
Cc: Samuel Holland, Mattijs Korpershoek, Patrick Delaunay,
Sean Anderson, Simon Glass
This fixes an error with trying to link against do_bootm() when
CONFIG_CMD_BOOTM is disabled.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/fastboot/fb_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
index 57b6182c46a..20aa80838ae 100644
--- a/drivers/fastboot/fb_common.c
+++ b/drivers/fastboot/fb_common.c
@@ -135,7 +135,7 @@ void fastboot_boot(void)
s = env_get("fastboot_bootcmd");
if (s) {
run_command(s, CMD_FLAG_ENV);
- } else {
+ } else if (IS_ENABLED(CONFIG_CMD_BOOTM)) {
static char boot_addr_start[20];
static char *const bootm_args[] = {
"bootm", boot_addr_start, NULL
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fastboot: Only call the bootm command if it is enabled
2023-02-20 6:14 [PATCH] fastboot: Only call the bootm command if it is enabled Samuel Holland
@ 2023-02-22 13:17 ` Mattijs Korpershoek
2023-02-22 19:27 ` Patrick DELAUNAY
2023-06-01 15:24 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2023-02-22 13:17 UTC (permalink / raw)
To: Samuel Holland, u-boot
Cc: Samuel Holland, Patrick Delaunay, Sean Anderson, Simon Glass
On lun., févr. 20, 2023 at 00:14, Samuel Holland <samuel@sholland.org> wrote:
> This fixes an error with trying to link against do_bootm() when
> CONFIG_CMD_BOOTM is disabled.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>
> drivers/fastboot/fb_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index 57b6182c46a..20aa80838ae 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -135,7 +135,7 @@ void fastboot_boot(void)
> s = env_get("fastboot_bootcmd");
> if (s) {
> run_command(s, CMD_FLAG_ENV);
> - } else {
> + } else if (IS_ENABLED(CONFIG_CMD_BOOTM)) {
> static char boot_addr_start[20];
> static char *const bootm_args[] = {
> "bootm", boot_addr_start, NULL
> --
> 2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fastboot: Only call the bootm command if it is enabled
2023-02-20 6:14 [PATCH] fastboot: Only call the bootm command if it is enabled Samuel Holland
2023-02-22 13:17 ` Mattijs Korpershoek
@ 2023-02-22 19:27 ` Patrick DELAUNAY
2023-06-01 15:24 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Patrick DELAUNAY @ 2023-02-22 19:27 UTC (permalink / raw)
To: Samuel Holland, u-boot; +Cc: Mattijs Korpershoek, Sean Anderson, Simon Glass
Hi,
On 2/20/23 07:14, Samuel Holland wrote:
> This fixes an error with trying to link against do_bootm() when
> CONFIG_CMD_BOOTM is disabled.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> drivers/fastboot/fb_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index 57b6182c46a..20aa80838ae 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -135,7 +135,7 @@ void fastboot_boot(void)
> s = env_get("fastboot_bootcmd");
> if (s) {
> run_command(s, CMD_FLAG_ENV);
> - } else {
> + } else if (IS_ENABLED(CONFIG_CMD_BOOTM)) {
> static char boot_addr_start[20];
> static char *const bootm_args[] = {
> "bootm", boot_addr_start, NULL
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fastboot: Only call the bootm command if it is enabled
2023-02-20 6:14 [PATCH] fastboot: Only call the bootm command if it is enabled Samuel Holland
2023-02-22 13:17 ` Mattijs Korpershoek
2023-02-22 19:27 ` Patrick DELAUNAY
@ 2023-06-01 15:24 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-06-01 15:24 UTC (permalink / raw)
To: Samuel Holland
Cc: u-boot, Mattijs Korpershoek, Patrick Delaunay, Sean Anderson,
Simon Glass
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Mon, Feb 20, 2023 at 12:14:58AM -0600, Samuel Holland wrote:
> This fixes an error with trying to link against do_bootm() when
> CONFIG_CMD_BOOTM is disabled.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-01 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 6:14 [PATCH] fastboot: Only call the bootm command if it is enabled Samuel Holland
2023-02-22 13:17 ` Mattijs Korpershoek
2023-02-22 19:27 ` Patrick DELAUNAY
2023-06-01 15:24 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox