From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: u-boot@lists.denx.de
Subject: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode
Date: Fri, 30 Oct 2020 19:20:20 +0100 [thread overview]
Message-ID: <87ft5vpod7.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <a976518c-8ef5-984f-32a2-6b42e29ba9ae@rock-chips.com> (Kever Yang's message of "Fri, 30 Oct 2020 23:16:02 +0800")
Kever Yang <kever.yang@rock-chips.com> writes:
> Hi Arnaud,
>
> ??? Thanks for your patch.
>
> ??? Please use module name as subject prefix instead of a file name,
> eg. "rockchip: video: vop".
>
ok. will fix.
> On 2020/10/27 ??9:21, Arnaud Patard (Rtp) wrote:
>> The current code is using an hard coded enum and the of node reg value of
>> endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order
>> is different between rk3288, rk3399 vop little, rk3399 vop big.
>>
>> A possible solution would be to make sure that the rk3288.dtsi and
>> rk3399.dtsi files have "expected" reg value or an other solution is
>> to find the kind of endpoint by comparing the endpoint compatible value.
>>
>> This patch is implementing the more flexible second solution.
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>>
>> Index: u-boot/arch/arm/include/asm/arch-rockchip/vop_rk3288.h
>> ===================================================================
>> --- u-boot.orig/arch/arm/include/asm/arch-rockchip/vop_rk3288.h
>> +++ u-boot/arch/arm/include/asm/arch-rockchip/vop_rk3288.h
>
> For the patch format, please make sure the u-boot is the root directory.
>
Can you please explain this point ? It's a valid patch which can be
applied with patch -p1. I've been generating patches with quilt for ages
and patches got merged in various projects including in the kernel even
before git, so I fail to get what's wrong with it.
Or are you telling me that uboot is accepting only patches generated with git ?
Arnaud
next prev parent reply other threads:[~2020-10-30 18:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:21 [patch v2 00/10] rk3399 (Pinebook pro) EDP support Arnaud Patard
2020-10-27 13:21 ` [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode Arnaud Patard
2020-10-27 22:31 ` Alper Nebi Yasak
2020-10-30 15:16 ` Kever Yang
2020-10-30 18:20 ` Arnaud Patard [this message]
2020-11-13 10:32 ` Kever Yang
2020-10-27 13:21 ` [patch v2 02/10] drivers/video/rockchip/rk_edp.c: Add rk3399 support Arnaud Patard
2020-10-27 22:32 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 03/10] drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration Arnaud Patard
2020-10-27 22:32 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 04/10] drivers/video/rockchip/rk_vop.c: Reserve efi fb memory Arnaud Patard
2020-10-27 22:33 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 05/10] rk3399-pinebook-pro-u-boot.dtsi: Enable edp Arnaud Patard
2020-10-27 14:32 ` Peter Robinson
2020-10-27 13:21 ` [patch v2 06/10] configs/pinebook-pro-rk3399_defconfig: enable SYS_USB_EVENT_POLL_VIA_INT_QUEUE Arnaud Patard
2020-10-27 13:21 ` [patch v2 07/10] drivers/pwm/rk_pwm.c: Fix default polarity Arnaud Patard
2020-10-27 22:34 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 08/10] drivers/video/rockchip/rk_vop.c: Fix format of fbbase in debug string Arnaud Patard
2020-10-27 22:36 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 09/10] drivers/video/rockchip/rk_edp.c: Add missing reset support Arnaud Patard
2020-10-27 22:37 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 10/10] drivers/video/rockchip/rk_vop.c: Add " Arnaud Patard
2020-10-27 22:37 ` Alper Nebi Yasak
2020-10-27 22:19 ` [patch v2 00/10] rk3399 (Pinebook pro) EDP support Alper Nebi Yasak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft5vpod7.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox