From: Peter Korsgaard <peter@korsgaard.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times
Date: Sat, 02 Apr 2016 20:57:06 +0200 [thread overview]
Message-ID: <87fuv3u9dp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1459622771-12704-1-git-send-email-hdegoede@redhat.com> (Hans de Goede's message of "Sat, 2 Apr 2016 20:46:09 +0200")
>>>>> "Hans" == Hans de Goede <hdegoede@redhat.com> writes:
> The probe function of the musb host driver can be called multiple
> times. The code assumes that it can safe the pointer to the allocated
> musb struct in the driver model priv_auto_alloc data, but this data
> gets free-ed on a probe failure or on removal, so we must safe the
> pointer elsewhere.
s/safe/save/ (twice).
Otherwise it looks sensibe to me.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-04-02 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 18:46 [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times Hans de Goede
2016-04-02 18:46 ` [U-Boot] [PATCH 2/3] musb: Properly call musb_stop() on probe failure Hans de Goede
2016-04-02 18:46 ` [U-Boot] [PATCH 3/3] dm: usb: Do not reprobe usb hosts on "usb tree" command Hans de Goede
2016-04-02 18:57 ` Peter Korsgaard [this message]
2016-04-02 21:39 ` [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times Hans de Goede
2016-04-05 9:37 ` Ian Campbell
2016-04-05 9:00 ` [U-Boot] [U-Boot, " Hans de Goede
2016-04-05 23:12 ` Marek Vasut
2016-04-06 12:21 ` Hans de Goede
2016-04-06 12:34 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuv3u9dp.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox