From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/7] Allow checking in multiple partitions for scan_dev_for_boot.
Date: Mon, 06 Oct 2014 23:07:25 -0700 [thread overview]
Message-ID: <87fvf0xvj6.fsf@aikidev.net> (raw)
In-Reply-To: <54336277.90904@nvidia.com>
Thanks for the review!
On 2014-10-06, Stephen Warren <swarren@nvidia.com> wrote:
> On 10/03/2014 03:08 PM, Vagrant Cascadian wrote:
>
> Some standalone description of this change, and justification for it,
> should really be present in the commit message. Patch 0/7 doesn't get
> applied anywhere.
Of course; that was a consequence of learning how patman/git-send-email
work... trial by fire... I'll use more verbose commit messages in the
future.
>> diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h
>
>> - "bootpart=1\0" \
>> + "boot_partitions=1\0" \
>
> Instead of searching a hard-coded list of partitions, I think it'd be
> better to have the script automatically determine which partition to
> boot from based on the partition tables' bootable flag or partition
> type. I had always intended these scripts to do that, but never got
> around to doing it. I think the $dev:$part syntax already chooses the
> first partition marked bootable if you don't specify a partition. Would
> that work?
I suspect that might work. I merely went with the simplest approach to
extend what was already there, by supporting an arbitrary number of
partitions to search, and leaving the defaults as is.
The BeagleBone Black board ships with various boot files on the first
FAT partition, but newer images available for it moved boot files
(kernel/initrd/dtb/uEnv.txt) onto the second (ext4?) partition, as the
FAT partition is exported as a multifunction device over USB... So
ideally u-boot could support multiple partitions to search, to support
multiple generations of images without having to manually configure
u-boot.
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141006/e638dc33/attachment.pgp>
next prev parent reply other threads:[~2014-10-07 6:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 22:08 [U-Boot] [RFC PATCH 0/7] Switch am335x_evm.h based boards to use config_distro_bootcmd Vagrant Cascadian
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 1/7] Allow checking in multiple partitions for scan_dev_for_boot Vagrant Cascadian
2014-10-07 3:48 ` Stephen Warren
2014-10-07 6:07 ` Vagrant Cascadian [this message]
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 2/7] Allow overriding boot_partitions default value by setting BOOTENV_BOOT_PARTITIONS before including config_distro_bootcmd Vagrant Cascadian
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 3/7] Add BOOTENV_INIT_COMMAND for commands that may be needed to run before bootcmd, such as setting the fdt file variables for platfroms that detect on boot Vagrant Cascadian
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 4/7] Add BOOTENV_POST_COMMAND, which is appended to the end of bootcmd Vagrant Cascadian
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 5/7] Only set CONFIG_BOOTDELAY if not already set Vagrant Cascadian
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 6/7] Add support for loading environment from uEnv.txt in config_distro_bootcmd Vagrant Cascadian
2014-10-07 3:55 ` Stephen Warren
2014-10-07 6:26 ` Vagrant Cascadian
2014-10-03 22:08 ` [U-Boot] [RFC PATCH 7/7] Switch am335x_evm.h to use config_distro_defaults and config_distro_bootcmd. Add scriptaddr to DEFAULT_LINUX_BOOT_ENV, as scriptaddr is used for boot scripts " Vagrant Cascadian
2014-10-24 16:22 ` Dennis Gilmore
2014-10-27 5:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvf0xvj6.fsf@aikidev.net \
--to=vagrant@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox