From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?iso-8859-1?Q?Klotzb=FCcher?= Date: Mon, 19 May 2008 09:51:20 +0200 Subject: [U-Boot-Users] [PATCH 02/17] examples/eepro100_eeprom: Fix memcpy to return destination pointer In-Reply-To: <4830E829.7020100@gmail.com> (Jerry Van Baren's message of "Sun\, 18 May 2008 22\:38\:33 -0400") References: <20080518222019.GC19480@game.jcrosoft.org> <20080518230336.5DA772476E@gemini.denx.de> <20080519012211.GD19480@game.jcrosoft.org> <4830E829.7020100@gmail.com> Message-ID: <87fxse20lj.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jerry Van Baren writes: > YES! YES! YES! This gets my vote. I marked the start of this thread > meaning to suggest using temp variables of the right type and get rid of > the complex casting crap, exactly what you did here. Ack, but BTW .... ...whats wrong with the generic memcpy, e.g. from lib_generic/string.c? Maybe this should be exported and used instead of duplicating generic code again and again? Best regards Markus Klotzbuecher -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de