U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andrea della Porta <andrea.porta@suse.com>
Cc: Joao Marcos Costa <jmcosta944@gmail.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH] fs/squashfs: Fix memory leak in sqfs_size_nest()
Date: Mon, 03 Mar 2025 09:21:46 +0100	[thread overview]
Message-ID: <87h64abk2t.fsf@bootlin.com> (raw)
In-Reply-To: <20250302182931.15519-1-andrea.porta@suse.com> (Andrea della Porta's message of "Sun, 2 Mar 2025 19:29:31 +0100")

Hi Andrea,

On 02/03/2025 at 19:29:31 +01, Andrea della Porta <andrea.porta@suse.com> wrote:

> In case MAX_SYMLINK_NEST is reached while determining the size
> on a symlink node, the function returns immediately.
> This would not free the resources after the free_strings: label
> causing a memory leak.
>
> Set the ret value and just break out of the switch to fix this.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

  reply	other threads:[~2025-03-03  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-02 18:29 [PATCH] fs/squashfs: Fix memory leak in sqfs_size_nest() Andrea della Porta
2025-03-03  8:21 ` Miquel Raynal [this message]
2025-03-06 15:41 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h64abk2t.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=andrea.porta@suse.com \
    --cc=jmcosta944@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox