public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: u-boot@lists.denx.de,  Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] Add imx93-var-som support
Date: Thu, 28 Dec 2023 15:54:19 +0100	[thread overview]
Message-ID: <87h6k274ys.fsf@gmail.com> (raw)
In-Reply-To: <CAOMZO5DEwTgffO6RZz8BaFq+bmxM170mz6wWN+MQ76ss7r8O2g@mail.gmail.com> (Fabio Estevam's message of "Wed, 13 Dec 2023 15:22:12 -0300")


Hello Fabio,

Thanks for the review!

> It would also be helpful to add doc/board/variscite/imx93_var_som.rst
> that explains
> how to build U-Boot for this board, how to get the firmware, ATF,
> binaries, etc, and how to flash it to the boot medium.

For now, I am testing the bootloaders I produce using those
instructions:
https://variwiki.com/index.php?title=Yocto_Build_U-Boot&release=mx93-yocto-mickledore-6.1.36_2.1.0-v1.1

I understand that it would be nice to have u-boot do the image
construction with the firmware, ATF and so on, like implemented on
imx8.

Do you think that it could be done in a follow-up patch, once
imx93-var-som support is merged?

> Please also submit the imx93-var-som-symphony.dts support to Linux so that
> it can get reviewed by the DT folks.

Done here:
https://lore.kernel.org/linux-devicetree/20231227170919.8771-1-othacehe@gnu.org/T/#t

> To not block the board support, I suggest sending a v2 without PTN5150
> support for now.

OK.

>> +/* Using ULP WDOG for reset */
>> +#define WDOG_BASE_ADDR          WDG3_BASE_ADDR
>
> Is this needed now that we use DM?

That specific define is needed as the ulp_wdog driver seems to require
it. I removed all the other unneeded defines in v2.

Thanks,

Mathieu

  reply	other threads:[~2023-12-28 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 11:45 [PATCH] Add imx93-var-som support Mathieu Othacehe
2023-12-13 18:22 ` Fabio Estevam
2023-12-28 14:54   ` Mathieu Othacehe [this message]
2023-12-28 15:20     ` Fabio Estevam
2023-12-28 15:22       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6k274ys.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=festevam@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox