Re: Bug#1012269: u-boot-exynos on Odroid XU4 searches for exynos5422-smdk5420xu4.dtb instead of exynos5422-odroidxu4.dtb

[Vagrant Cascadian <vagrant@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 2951 bytes --]

On 2022-12-25, Jochen Sprickerhof wrote:
> * Vagrant Cascadian <vagrant@debian.org> [2022-11-04 14:22]:
>>On 2022-06-02, Jochen Sprickerhof wrote:
>>> with the latest u-boot-exynos in unstable it tries to load
>>> exynos5422-smdk5420xu4.dtb whereas linux-image-5.17.0-3-armmp only
>>> contains exynos5422-odroidxu4.dtb. This was not the case with 2022.01+dfsg-2:
>>>
>>> U-Boot 2022.04+dfsg-2+b1 (May 14 2022 - 21:25:25 +0000) for ODROID-XU3/XU4/HC1/HC2
>>> [..]
>>> Retrieving file: /usr/lib/linux-image-5.17.0-3-armmp/exynos5422-smdk5420xu4.dtb
>>> ** File not found /usr/lib/linux-image-5.17.0-3-armmp/exynos5422-smdk5420xu4.dtb **
>>>
>>> U-Boot 2022.01+dfsg-2 (Jan 26 2022 - 19:58:27 +0000) for ODROID-XU3/XU4/HC1/HC2
>>> [..]
>>> Retrieving file: /usr/lib/linux-image-5.17.0-3-armmp/exynos5422-odroidxu4.dtb
...
>>My guess is this was broken in 2022.04, and fixed in 2022.07-rc5 with
>>this commit:
...
>>Could you test 2022.10 from unstable and/or pull 2022.07 from
>>snapshots.debian.org and test it?
>
> I finally found time to test, sorry for the delay. Still the same 
> problem:
>
> U-Boot 2022.10+dfsg-2 (Dec 23 2022 - 23:18:44 +0000) for ODROID-XU3/XU4/HC1/HC2
>
> CPU:   Exynos5422 @ 800 MHz
> DRAM:  2 GiB
> Core:  73 devices, 12 uclasses, devicetree: separate
> MMC:   EXYNOS DWMMC: 0, EXYNOS DWMMC: 2
> Loading Environment from MMC... *** Warning - bad CRC, using default environment
>
> In:    serial
> Out:   serial
> Err:   serial
> Model: Odroid XU3/XU4/HC1/HC2 based on Exynos5422
> Type:  xu4
> Boot device: MMC(0)
...
> Retrieving file: /usr/lib/linux-image-6.0.0-6-armmp/exynos5422-smdk5420xu4.dtb
> ** File not found /usr/lib/linux-image-6.0.0-6-armmp/exynos5422-smdk5420xu4.dtb **
...
> The workaround with:
>
> ln -s exynos5422-odroidxu4.dtb exynos5422-smdk5420xu4.dtb

Hrm. This suggests the fix might not have been effective, which should
have been included in 2022.07... CCing upstream...

commit e744bf3a4ba442a0e9ee1c509c70e1452e3a15d0
Author: Tom Rini <trini@konsulko.com>
Date:   Wed Jun 8 14:30:14 2022 -0400

	odroid_xu3: Fix board environment variable

	When migrating CONFIG_CONS_INDEX to Kconfig, on this platform we changed
	what "board" evaluated to in the environment.  This in turn meant that
	we would no longer try and find the correct fdtfile via the normal
	distro boot logic.  Fix this by overriding board in the default
	environment, as done on other platforms where CONFIG_SYS_BOARD is not
	what we want to be in the board environment variable.

	Fixes: f76750d11133 ("Convert CONFIG_CONS_INDEX et al to Kconfig")
	Reported-by: Gabriel Hojda <ghojda@yo2urs.ro>
	Tested-by: Gabriel Hojda <ghojda@yo2urs.ro>
	Signed-off-by: Tom Rini <trini@konsulko.com>


Alternately... did you at any point run saveenv? This might have stored
the incorrect value... and then it might not probe for the correct
value.


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]