[U-Boot] [PATCH V2 6/7] ARM: imx: novena: Enable DM PCI

Marek Vasut
2019-06-09T01:49:57Z

On 6/8/19 10:45 PM, Stefano Babic wrote:
> Hi Marek,
>
> On 17/05/19 20:32, Marek Vasut wrote:
>> Enable DM PCI support on iMX6Q Novena.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Vagrant Cascadian <vagrant@debian.org>
>> ---
>> V2: New patch
>> ---
>> configs/novena_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/novena_defconfig b/configs/novena_defconfig
>> index c5dbbb0b4d..bbed972a44 100644
>> --- a/configs/novena_defconfig
>> +++ b/configs/novena_defconfig
>> @@ -56,6 +56,7 @@ CONFIG_PHY_MICREL=y
>> CONFIG_PHY_MICREL_KSZ90X1=y
>> CONFIG_MII=y
>> CONFIG_PCI=y
>> +CONFIG_DM_PCI=y
>> CONFIG_PINCTRL=y
>> CONFIG_PINCTRL_IMX6=y
>> CONFIG_DM_SCSI=y
>>
>
> I cannot build novena with this enabled - do you see the same error or
> am I missing something ?
>
> arm: + novena
> + pci_set_ops(hose,
> + ^~~~~~~~~~~
> +drivers/pci/pcie_imx.c:686:7: error:
> ?pci_hose_read_config_byte_via_dword? undeclared (first use in this
> function)
> + pci_hose_read_config_byte_via_dword,
> + ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +drivers/pci/pcie_imx.c:686:7: note: each undeclared identifier is
> reported only once for each function it appears in
> +drivers/pci/pcie_imx.c:687:7: error:
> ?pci_hose_read_config_word_via_dword? undeclared (first use in this
> function)
> + pci_hose_read_config_word_via_dword,
> +drivers/pci/pcie_imx.c:689:7: error:
> ?pci_hose_write_config_byte_via_dword? undeclared (first use in this
> function)
> + pci_hose_write_config_byte_via_dword,
> + ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +drivers/pci/pcie_imx.c:690:7: error:
> ?pci_hose_write_config_word_via_dword? undeclared (first use in this
> function)
> + pci_hose_write_config_word_via_dword,
> + pci_register_hose(hose);
> + ^~~~~~~~~~~~~~~~~
> + hose->last_busno = pci_hose_scan(hose);
> + ^~~~~~~~~~~~~
> +make[3]: *** [drivers/pci/pcie_imx.o] Error 1
> +make[2]: *** [drivers/pci] Error 2
> +make[1]: *** [drivers] Error 2
> +make: *** [sub-make] Error 2
> w+drivers/pci/pcie_imx.c: In function ?imx_pcie_init?:
> w+drivers/pci/pcie_imx.c:685:2: warning: implicit declaration of
> function ?pci_set_ops? [-Wimplicit-function-declaration]
> w+drivers/pci/pcie_imx.c:697:3: warning: implicit declaration of
> function ?pci_register_hose? [-Wimplicit-function-declaration]
> w+drivers/pci/pcie_imx.c:698:22: warning: implicit declaration of
> function ?pci_hose_scan? [-Wimplicit-function-declaration]

I collected the patches here [1], CI passed:

https://github.com/marex/u-boot-imx/tree/imx-dm

--
Best regards,
Marek Vasut