public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288
Date: Sat, 10 Sep 2016 12:01:30 -0700	[thread overview]
Message-ID: <87h99na8ad.fsf@aikidev.net> (raw)
In-Reply-To: <b57e0037-b804-9736-3edf-ba90438bda9d@rock-chips.com>

On 2016-09-10, Ziyuan Xu wrote:
> On 2016?09?09? 03:28, Vagrant Cascadian wrote:
>> On 2016-09-08, Kever Yang wrote:
>>> The rk3288 spl size is very close to 32KB while the rk3288 bootrom
>>> has the limitation of maximum size of SPL is 32KB. After apply this
>>> patch, the SPL size will exceed 32KB if we do not enable macro
>>> CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.

With CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y, it fails to boot with no output
on the console.


>>> This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.
>> Thanks for the patch!
>>
>> Unfortunately, fails to build the firefly-rk3288 target, using
>> arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
>> u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:
>>
>>    CC      spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
>> arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
>>    'conv_of_platdata':
>> arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
>>    dtd_rockchip_rk3288_dmc' has no member named 'rockchip_num_channels';
>>    did you mean 'rockchip_noc'?
>>    plat->num_channels = of_plat->rockchip_num_channels;
>
> -       plat->num_channels = of_plat->rockchip_num_channels;
> +       plat->num_channels = 2;
>
> firefly-rk3288 deploy CONFIG_OF_PLATDATA,  driver read platform data
> from include/generated/dt-structs.h which is generated according to dts
> file.
> Please try above change.

With this change, it builds, but it hangs at boot:

  U-Boot SPL 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28)
  Trying to boot from MMC1


  U-Boot 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28 +0000)

  Model: Firefly-RK3288
  DRAM:

This is on a firefly with 2GB of ram. I also have one with 4GB of ram,
hence my interest in this patch series!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160910/133e1171/attachment.sig>

  reply	other threads:[~2016-09-10 19:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 13:04 [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288 Kever Yang
2016-09-08 13:04 ` [U-Boot] [PATCH 1/2] rk3288: sdram: auto-detect the capacity Kever Yang
2016-09-08 13:04 ` [U-Boot] [PATCH 2/2] dts: rk3288: remove node in dmc which not need anymore Kever Yang
2016-09-08 19:28 ` [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288 Vagrant Cascadian
2016-09-10 13:36   ` Ziyuan Xu
2016-09-10 19:01     ` Vagrant Cascadian [this message]
2016-09-12  2:01       ` Ziyuan Xu
2016-09-15 12:00         ` Sandy Patterson
2016-09-18  2:18           ` Kever Yang
2016-09-18 19:34           ` Vagrant Cascadian
2016-09-19 13:33             ` Sandy Patterson
2016-09-20  3:34               ` Kever Yang
2016-09-20 13:20                 ` Sandy Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h99na8ad.fsf@aikidev.net \
    --to=vagrant@debian.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox