From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Carlo Caione <ccaione@baylibre.com>,
u-boot@lists.u-boot-project.org,
GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>
Cc: "Suhrid Subramaniam" <Suhrid.Subramaniam@mediatek.com>,
"Macpaul Lin (林智斌)" <Macpaul.Lin@mediatek.com>,
"Pablo Sun (孫毓翔)" <pablo.sun@mediatek.com>,
"Arnaud Ferraris" <arnaud.ferraris@collabora.com>,
"Tom Rini" <trini@konsulko.com>, "Simon Glass" <sjg@chromium.org>,
"Sam Day" <me@samcday.com>,
"Quentin Schulz" <quentin.schulz@cherry.de>,
"Carlo Caione" <ccaione@baylibre.com>,
"David Lechner" <dlechner@baylibre.com>,
"Vitor Sato Eschholz" <vsatoes@baylibre.com>,
"Lukasz Majewski" <lukma@denx.de>, "Marek Vasut" <marex@denx.de>,
"Peng Fan" <peng.fan@nxp.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Julien Masson" <jmasson@baylibre.com>,
"Alexey Charkov" <alchark@gmail.com>,
"Adrian Freihofer" <adrian.freihofer@siemens.com>,
"Francois Berder" <fberder@outlook.fr>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"Vincent Jardin" <vjardin@free.fr>,
"Peter Robinson" <pbrobinson@gmail.com>
Subject: Re: [PATCH RFC v3 1/5] fastboot: factor out the USB session runner
Date: Mon, 17 Aug 2026 10:49:55 +0200 [thread overview]
Message-ID: <87ik59i11o.fsf@kernel.org> (raw)
In-Reply-To: <20260731-ccaione-upstream-spl-fastboot-v3-1-dbea3ff4529e@baylibre.com>
Hi Carlo,
Thank you for the patch.
On Fri, Jul 31, 2026 at 10:29, Carlo Caione <ccaione@baylibre.com> wrote:
> The fastboot command currently owns USB gadget setup, protocol
> initialization, the service loop and teardown. This prevents callers
> which do not use the command line from starting USB fastboot without
> duplicating the same session lifecycle.
>
> Move that lifecycle into fastboot_usb_run() and leave cmd/fastboot.c
> responsible only for argument parsing and transport selection.
> Initialize network sessions in their transport path so their existing
> behavior is preserved.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Sorry for the review delay. This looks good to me!
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
next prev parent reply other threads:[~2026-08-17 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 8:29 [PATCH RFC v3 0/5] Add fastboot to SPL Carlo Caione
2026-07-31 8:29 ` [PATCH RFC v3 1/5] fastboot: factor out the USB session runner Carlo Caione
2026-08-17 8:49 ` Mattijs Korpershoek [this message]
2026-07-31 8:29 ` [PATCH RFC v3 2/5] fastboot: use the common handler for USB reboot Carlo Caione
2026-08-17 8:56 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 3/5] fastboot: make shared configuration checks phase-aware Carlo Caione
2026-08-17 9:11 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 4/5] image: sparse: add phase-aware SPL support Carlo Caione
2026-08-17 9:34 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 5/5] fastboot: add " Carlo Caione
2026-08-17 12:35 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik59i11o.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=Macpaul.Lin@mediatek.com \
--cc=Suhrid.Subramaniam@mediatek.com \
--cc=adrian.freihofer@siemens.com \
--cc=alchark@gmail.com \
--cc=arnaud.ferraris@collabora.com \
--cc=ccaione@baylibre.com \
--cc=dlechner@baylibre.com \
--cc=fberder@outlook.fr \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=jmasson@baylibre.com \
--cc=lukma@denx.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marex@denx.de \
--cc=me@samcday.com \
--cc=neil.armstrong@linaro.org \
--cc=pablo.sun@mediatek.com \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=vjardin@free.fr \
--cc=vsatoes@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox