public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rasmus Villemoes <ravi@prevas.dk>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de,
	 Anatolij Gustschin <ag.dev.uboot@gmail.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	 Ion Agorria <ion@agorria.com>,
	 Patrice Chotard <patrice.chotard@foss.st.com>,
	 Sughosh Ganu <sughosh.ganu@arm.com>,
	 Svyatoslav Ryhel <clamor95@gmail.com>,
	 Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v4 2/2] kbuild: Use if_changed for font and splash .incbin rules
Date: Mon, 13 Apr 2026 23:16:30 +0200	[thread overview]
Message-ID: <87ik9umuhd.fsf@prevas.dk> (raw)
In-Reply-To: <20260413131541.2091541-2-sjg@chromium.org> (Simon Glass's message of "Mon, 13 Apr 2026 07:15:38 -0600")

On Mon, Apr 13 2026, Simon Glass <sjg@chromium.org> wrote:

> The generated .S files for fonts and splash screens use .incbin with the
> full prerequisite path. When building with O= this bakes an absolute
> path into the .S file. If the build directory is later used on a
> different machine (e.g. in a container), the assembler cannot find the
> source file.
>
> Follow the existing DTB convention: rename the object targets to use
> compound suffixes (.ttf.o, .bmp.o), switch the pattern rules from
> direct $(call cmd,...) to FORCE + $(call if_changed,...), and register
> the new suffixes with intermediate_targets so that kbuild loads their
> .cmd files. This lets if_changed detect when the recorded command
> (including source paths) has changed and regenerate the .S file
> automatically.
>
> The EFI rule is left unchanged since its prerequisite is a generated
> file in the build directory, like the DTB and DTBO rules.
>
> The intermediate_targets entries stay in scripts/Makefile.build rather
> than moving to scripts/Makefile.lib-u-boot, because that file is
> included before intermediate_targets is defined and 'targets' is ':=',
> so a '$(call intermediate_targets, ...)' inside it would expand to
> empty and silently drop the entries. To keep the upstream block
> untouched, the U-Boot additions go in a separate 'targets +=' block
> immediately below.
>
> Suggested-by: Rasmus Villemoes <ravi@prevas.dk>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Rasmus Villemoes <ravi@prevas.dk>

  reply	other threads:[~2026-04-13 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 13:15 [PATCH v4 1/2] kbuild: Move U-Boot .incbin rules to Makefile.lib-u-boot Simon Glass
2026-04-13 13:15 ` [PATCH v4 2/2] kbuild: Use if_changed for font and splash .incbin rules Simon Glass
2026-04-13 21:16   ` Rasmus Villemoes [this message]
2026-04-13 21:16 ` [PATCH v4 1/2] kbuild: Move U-Boot .incbin rules to Makefile.lib-u-boot Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik9umuhd.fsf@prevas.dk \
    --to=ravi@prevas.dk \
    --cc=ag.dev.uboot@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=ion@agorria.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@arm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox