U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Simon Glass <sjg@chromium.org>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH v2 09/14] bootstd: Tidy up comments on the boothmeth drivers
Date: Tue, 16 Jul 2024 09:42:37 +0200	[thread overview]
Message-ID: <87ikx5n5oy.fsf@baylibre.com> (raw)
In-Reply-To: <20240716070419.1897560-10-sjg@chromium.org>

Hi Simon,

Thank you for the patch.

On mar., juil. 16, 2024 at 08:04, Simon Glass <sjg@chromium.org> wrote:

> Fix a typo in the comment and add one to the EFI driver too.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>
> (no changes since v1)
>
>  boot/bootmeth_efi.c      | 1 +
>  boot/bootmeth_extlinux.c | 2 +-
>  boot/bootmeth_script.c   | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
> index 5a4c125835a..56a6e47f5b2 100644
> --- a/boot/bootmeth_efi.c
> +++ b/boot/bootmeth_efi.c
> @@ -394,6 +394,7 @@ static const struct udevice_id distro_efi_bootmeth_ids[] = {
>  	{ }
>  };
>  
> +/* Put a number before 'efi' to provide a default ordering */
>  U_BOOT_DRIVER(bootmeth_4efi) = {
>  	.name		= "bootmeth_efi",
>  	.id		= UCLASS_BOOTMETH,
> diff --git a/boot/bootmeth_extlinux.c b/boot/bootmeth_extlinux.c
> index 9b55686948f..fbb05ef928e 100644
> --- a/boot/bootmeth_extlinux.c
> +++ b/boot/bootmeth_extlinux.c
> @@ -183,7 +183,7 @@ static const struct udevice_id extlinux_bootmeth_ids[] = {
>  	{ }
>  };
>  
> -/* Put an number before 'extlinux' to provide a default ordering */
> +/* Put a number before 'extlinux' to provide a default ordering */
>  U_BOOT_DRIVER(bootmeth_1extlinux) = {
>  	.name		= "bootmeth_extlinux",
>  	.id		= UCLASS_BOOTMETH,
> diff --git a/boot/bootmeth_script.c b/boot/bootmeth_script.c
> index 0e05d28d4d9..24da47c7259 100644
> --- a/boot/bootmeth_script.c
> +++ b/boot/bootmeth_script.c
> @@ -250,7 +250,7 @@ static const struct udevice_id script_bootmeth_ids[] = {
>  	{ }
>  };
>  
> -/* Put an number before 'script' to provide a default ordering */
> +/* Put a number before 'script' to provide a default ordering */
>  U_BOOT_DRIVER(bootmeth_2script) = {
>  	.name		= "bootmeth_script",
>  	.id		= UCLASS_BOOTMETH,
> -- 
> 2.34.1

  reply	other threads:[~2024-07-16  7:42 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  7:04 [PATCH v2 00/14] doc: Add documentation for bootmeths Simon Glass
2024-07-16  7:04 ` [PATCH v2 01/14] MAINTAINERS: Rename BOOTDEVICE Simon Glass
2024-07-16  7:34   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 02/14] doc: Move bootstd into its own directory Simon Glass
2024-07-16  7:35   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 03/14] doc: Mention automatic binding of bootmeths Simon Glass
2024-07-16  7:36   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 04/14] doc: Add a description for bootmeth_extlinux Simon Glass
2024-07-16  7:37   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 05/14] doc: Add a description for bootmeth_pxe Simon Glass
2024-07-16  7:38   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 06/14] doc: Add a description for bootmeth_qfw Simon Glass
2024-07-16  7:40   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 07/14] doc: Add a description for bootmeth_cros Simon Glass
2024-07-16  7:41   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 08/14] doc: Add a description for bootmeth_sandbox Simon Glass
2024-07-16  7:41   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 09/14] bootstd: Tidy up comments on the boothmeth drivers Simon Glass
2024-07-16  7:42   ` Mattijs Korpershoek [this message]
2024-07-16  7:04 ` [PATCH v2 10/14] bootstd: Correct handling of script from network Simon Glass
2024-07-16  7:45   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 11/14] doc: Add a description for bootmeth_script Simon Glass
2024-07-16  7:49   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 12/14] doc: Add a link to VBE from the bootstd docs Simon Glass
2024-07-16  7:50   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 13/14] boot: Correct indentation in efi bootmeth Simon Glass
2024-07-16  7:50   ` Mattijs Korpershoek
2024-07-16  7:04 ` [PATCH v2 14/14] doc: Describe the bootstd settings Simon Glass
2024-07-16  7:51   ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikx5n5oy.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox