From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Igor Prusov <ivprusov@salutedevices.com>,
Marek Vasut <marex@denx.de>, Nishanth Menon <nm@ti.com>,
Tom Rini <trini@konsulko.com>
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] usb: dwc3: support USB 3.1 controllers
Date: Tue, 16 Apr 2024 11:56:08 +0200 [thread overview]
Message-ID: <87il0h4onb.fsf@baylibre.com> (raw)
In-Reply-To: <20240411160527.835767-1-caleb.connolly@linaro.org>
Hi Caleb,;
Thank you for the patch.
On jeu., avril 11, 2024 at 18:05, Caleb Connolly <caleb.connolly@linaro.org> wrote:
> The revision is different for these, add the additional check as in
> xhci-dwc3 core_init code.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/usb/dwc3/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 96e850b7170f..db045f5822d4 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -594,9 +594,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
> int ret;
>
> reg = dwc3_readl(dwc->regs, DWC3_GSNPSID);
> /* This should read as U3 followed by revision number */
> - if ((reg & DWC3_GSNPSID_MASK) != 0x55330000) {
> + if ((reg & DWC3_GSNPSID_MASK) != 0x55330000 &&
> + (reg & DWC3_GSNPSID_MASK) != 0x33310000) {
> dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
> ret = -ENODEV;
> goto err0;
> }
> --
> 2.44.0
next prev parent reply other threads:[~2024-04-16 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 16:05 [PATCH] usb: dwc3: support USB 3.1 controllers Caleb Connolly
2024-04-12 8:34 ` neil.armstrong
2024-04-16 9:56 ` Mattijs Korpershoek [this message]
2024-04-21 20:38 ` Marek Vasut
2024-04-22 10:53 ` Caleb Connolly
2024-04-23 0:50 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il0h4onb.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=caleb.connolly@linaro.org \
--cc=ivprusov@salutedevices.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marex@denx.de \
--cc=nm@ti.com \
--cc=patrice.chotard@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox