public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Manorit Chawdhry <m-chawdhry@ti.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Manorit Chawdhry <m-chawdhry@ti.com>
Subject: Re: [PATCH 1/2] include: env: ti: ti_common: Fix a missing semicolon
Date: Tue, 09 Jan 2024 15:16:04 +0100	[thread overview]
Message-ID: <87il42wq1n.fsf@baylibre.com> (raw)
In-Reply-To: <20240108-b4-upstream-fix-semicolon-v1-1-9437b3dc90ea@ti.com>

Hi Manorit,

Thank you for the patch.

On lun., janv. 08, 2024 at 13:48, Manorit Chawdhry <m-chawdhry@ti.com> wrote:

> Fix a missing semicolon that leads to syntax error while booting j721s2.
>
>     Importing environment from mmc1 ...
>     syntax error at 'run'HUSH died!
>
> Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally")
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  include/env/ti/ti_common.env | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env
> index f0f89a228767..5473f633aa7d 100644
> --- a/include/env/ti/ti_common.env
> +++ b/include/env/ti/ti_common.env
> @@ -27,7 +27,7 @@ bootcmd_ti_mmc=
>  #if CONFIG_CMD_REMOTEPROC
>  	if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1;
>  		then run main_cpsw0_qsgmii_phyinit;
> -	fi
> +	fi;
>  	run boot_rprocs;
>  #endif
>  	if test ${boot_fit} -eq 1;
>
> -- 
> 2.43.0

  reply	other threads:[~2024-01-09 14:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08  8:18 [PATCH 0/2] Boot fixup Manorit Chawdhry
2024-01-08  8:18 ` [PATCH 1/2] include: env: ti: ti_common: Fix a missing semicolon Manorit Chawdhry
2024-01-09 14:16   ` Mattijs Korpershoek [this message]
2024-01-19 16:08   ` Tom Rini
2024-01-08  8:18 ` [PATCH 2/2] include: env: ti: add default for do_main_cpsw0_qsgmii_phyinit Manorit Chawdhry
2024-01-09 14:29   ` Mattijs Korpershoek
2024-01-19 16:08   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il42wq1n.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=m-chawdhry@ti.com \
    --cc=s-vadapalli@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox