From: Vagrant Cascadian <vagrant@debian.org>
To: Tom Rini <trini@konsulko.com>, Fabio Estevam <festevam@gmail.com>
Cc: Peter Robinson <pbrobinson@gmail.com>,
Simon Glass <sjg@chromium.org>,
Otavio Salvador <otavio@ossystems.com.br>,
Marek Vasut <marex@denx.de>, U-Boot-Denx <u-boot@lists.denx.de>
Subject: Re: v2023.01: u-boot-tools build failure
Date: Fri, 13 Jan 2023 15:36:47 -0800 [thread overview]
Message-ID: <87ilhaqa5s.fsf@contorta> (raw)
In-Reply-To: <20230113212856.GZ3787616@bill-the-cat>
[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]
On 2023-01-13, Tom Rini wrote:
> On Fri, Jan 13, 2023 at 06:26:00PM -0300, Fabio Estevam wrote:
>> I am trying to upgrade U-Boot to 2023.01 in OpenEmbedded, but I see
>> the following error when trying to build u-boot-tools:
>>
>> | /bin/sh: line 1: tools/bmp_logo: No such file or directory
>>
>> Reverting the commit below makes u-boot-tools build again:
>>
>> commit 1cfba53ca46cade2dbf4e067afc8c19e72909a4b
>> Author: Peter Robinson <pbrobinson@gmail.com>
>> Date: Thu Nov 24 14:05:59 2022 +0000
>>
>> config: tools only: add VIDEO to build bmp_logo
>>
>> Pre 2023.01 the bmp_logo was built as part of the tools-only_defconfig
>> build, something changed and the VIDEO dep needed to build it
>> is no longer pulled in so fix that by explicitly defining it.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> u-boot-tools-native builds fine though.
>>
>> What would be the correct way to fix this?
>
> Vagrant also hit this for Debian as Fedora cross-builds bmp_logo and
> ships it in host tools, but the logo header files that we generate with
> bmp_logo need the tool host built. And the same flag, VIDEO_LOGO
> (default y if VIDEO, basically) controls both the tool and the headers.
> I think the first thing to figure out is if bmp_logo should be shipped
> as a host tool, or not.
FWIW, we have not shipped bmp_logo in Debian's u-boot-tools package, so
we have managed without it, though curious what the use-case might be.
It is disabled in Debian for now:
https://salsa.debian.org/debian/u-boot/-/blob/debian/2023.01+dfsg-1/debian/patches/tools-disable-video-logo
... at least until a better fix comes along. :)
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2023-01-13 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 21:26 v2023.01: u-boot-tools build failure Fabio Estevam
2023-01-13 21:28 ` Tom Rini
2023-01-13 23:36 ` Vagrant Cascadian [this message]
2023-01-15 19:34 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilhaqa5s.fsf@contorta \
--to=vagrant@debian.org \
--cc=festevam@gmail.com \
--cc=marex@denx.de \
--cc=otavio@ossystems.com.br \
--cc=pbrobinson@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox