public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Setting processor endianess for USB modules
Date: Thu, 08 May 2008 10:33:39 +0200	[thread overview]
Message-ID: <87iqxpb3fg.fsf@denx.de> (raw)
In-Reply-To: <OF6804A6C3.22B0B8D2-ONC1257440.00360AB9-C1257440.00363151@kathrein.de> (Christian Eggers's message of "Mon\, 5 May 2008 11\:51\:55 +0200")

Dear Christian,

Thank you for your contribution. Unfortunately I have problems applying
your patch against a top of git tree:

[mk at pollux u-boot-mainline]$ patch  -p5 --dry-run < ~/2008-05-05-usb-remove-LITTLE_ENDIAN-define
missing header for unified diff at line 4 of patch
patching file common/usb.c
missing header for unified diff at line 130 of patch
patching file common/usb_kbd.c
missing header for unified diff at line 177 of patch
patching file common/usb_storage.c
Hunk #2 succeeded at 475 (offset 3 lines).
Hunk #4 succeeded at 1223 (offset 3 lines).
missing header for unified diff at line 241 of patch
patching file drivers/usb/usb_ohci.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 

I would suggest you use git for generating and sending patches.

Also please make sure to read the guidelines for submitting patches in
the README. Especially:

 - provide a changelog entry for the logs
 - send patches inline
 - if you don't use git for generating patches,@least run diff from the
   parent directory of U-Boot
 - don't send html mails, the makes it impossible to use git-am

>    Registergericht / Register court: Amtsgericht Traunstein, HRA 460 /
>    local court Traunstein, certificate of registration no. 460
>    Gesch?ftsf?hrender pers?nlich haftender Gesellschafter / Personally
>    liable managing partner: Prof. Dr. Dr. h.c. Anton Kathrein,
>    Dipl.-Betriebswirt (MBA-equivalent)
>    Erf?llungsort und Gerichtsstand / Place of performance and place of
>    jurisdiction: Rosenheim
>    This e-mail is confidential and may contain privileged information. If
>    you have received this communication in error, please notify us
>    immediately by responding to this email and then delete it from your
>    system. The sender therefore does not accept liability for any errors
>    or omissions in the contents of this message which arise as a result of
>    e-mail transmission. We believe but do not warrant that this e-mail and
>    any attachments are virus free. You must therefore take full
>    responsibility for virus checking.

And if you can, please avoid sending this to public mailings lists.

Please cleanup and resubmit.

Thanks!

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2008-05-08  8:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05  9:51 [U-Boot-Users] [PATCH] Setting processor endianess for USB modules Christian Eggers
2008-05-08  8:33 ` Markus Klotzbücher [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-05-21 19:27 Christian Eggers
2008-05-21 19:41 ` Wolfgang Denk
2008-05-21 20:12 Christian Eggers
2008-05-21 20:40 ` Wolfgang Denk
2008-05-22 15:49   ` Jon Loeliger
2008-05-22 16:08     ` Wolfgang Denk
2008-05-25 19:39   ` Christian Eggers
2008-05-22 17:32 ` Markus Klotzbücher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqxpb3fg.fsf@denx.de \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox