Re: [PATCH 03/18] gadget: f_thor: annotate switch/case fallthrough

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Andre,

Thank you for the patch.

On jeu., mars 27, 2025 at 15:32, Andre Przywara <andre.przywara@arm.com> wrote:

> Even though we seem to catch POWEROFF and EFSCLEAR commands in the THOR
> protocol request handling, we ultimately do not seem to handle them
> (apart from sending a response), so those commands still print an error
> message.
>
> Annotate the switch/case fallthrough in this case, to make this clear to
> the compiler.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  drivers/usb/gadget/f_thor.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c
> index 54372118348..540b9f88237 100644
> --- a/drivers/usb/gadget/f_thor.c
> +++ b/drivers/usb/gadget/f_thor.c
> @@ -138,6 +138,7 @@ static int process_rqt_cmd(struct udevice *udc, const struct rqt_box *rqt)
>  	case RQT_CMD_POWEROFF:
>  	case RQT_CMD_EFSCLEAR:
>  		send_rsp(udc, rsp);
> +		fallthrough;
>  	default:
>  		printf("Command not supported -> cmd: %d\n", rqt->rqt_data);
>  		return -EINVAL;
> -- 
> 2.25.1