Re: [PATCH] usb: gadget: usbhs: Add Renesas USBHS device driver

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Marek,

Sorry for the review delay and thank you for the patch.

On jeu., juin 20, 2024 at 02:55, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> From: Vitaliy Vasylskyy <vitaliy.vasylskyy@globallogic.com>
>
> Add UDC driver for Renesas USBHS controller found in R-Car Gen3 SoCs.
> This is mostly ported from the Linux kernel, with additional porting
> glue. The code has been synchronized with 1b4861e32e46 ("Linux 6.9.3")
> and cleaned up and ported to DM since the original implementation by
> Vitaliy.
>
> Signed-off-by: Vitaliy Vasylskyy <vitaliy.vasylskyy@globallogic.com>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Note that the driver does have a few checkpatch warnings in it, those
> also partly come from Linux.
> ---
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Vitaliy Vasylskyy <vitaliy.vasylskyy@globallogic.com>

I've reviewed this by comparing this patch to the Linux stable 6.9.3
codebase located in drivers/usb/renesas_usbhs/ and the
phy driver (drivers/usb/renesas_usbhs/)

While I notice some differences, such as:
* no USB host support (no VBUS control support)
* no dma mapping control support
* no support for the older RCar controllers (rcar2)

This looks good overall.

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

[...]


> ---
> -- 
> 2.43.0