From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, u-boot@lists.denx.de
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Lukasz Majewski <lukma@denx.de>, Nishanth Menon <nm@ti.com>,
Simon Glass <sjg@chromium.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 10/11] usb: gadget: sandbox: Drop dm_usb_gadget_handle_interrupts()
Date: Tue, 18 Jun 2024 09:45:08 +0200 [thread overview]
Message-ID: <87jzimitiz.fsf@baylibre.com> (raw)
In-Reply-To: <20240614005309.34433-11-marek.vasut+renesas@mailbox.org>
Hi Marek,
Thank you for the patch.
On ven., juin 14, 2024 at 02:51, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:
> Drop dm_usb_gadget_handle_interrupts() in favor of empty default
> implementation of the same in drivers/usb/gadget/udc/udc-uclass.c .
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@lists.denx.de
> ---
> drivers/usb/host/usb-sandbox.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/usb-sandbox.c b/drivers/usb/host/usb-sandbox.c
> index e26f0b292ed..f687fe2c430 100644
> --- a/drivers/usb/host/usb-sandbox.c
> +++ b/drivers/usb/host/usb-sandbox.c
> @@ -123,12 +123,7 @@ static int sandbox_submit_int(struct udevice *bus, struct usb_device *udev,
> return ret;
> }
>
> -#if CONFIG_IS_ENABLED(DM_USB_GADGET)
> -int dm_usb_gadget_handle_interrupts(struct udevice *dev)
> -{
> - return 0;
> -}
> -#else
> +#if !CONFIG_IS_ENABLED(DM_USB_GADGET)
> int usb_gadget_register_driver(struct usb_gadget_driver *driver)
> {
> struct sandbox_udc *dev = this_controller;
> --
> 2.43.0
next prev parent reply other threads:[~2024-06-18 7:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 0:51 [PATCH 00/11] usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass Marek Vasut
2024-06-14 0:51 ` [PATCH 01/11] " Marek Vasut
2024-06-18 7:12 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 02/11] usb: gadget: cdns3: Convert interrupt handling to usb_gadget_generic_ops Marek Vasut
2024-06-18 7:18 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 03/11] usb: gadget: dwc2: " Marek Vasut
2024-06-18 7:20 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 04/11] usb: gadget: dwc3: " Marek Vasut
2024-06-18 7:27 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 05/11] usb: gadget: max3420: " Marek Vasut
2024-06-18 7:28 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 06/11] usb: gadget: mtu3: " Marek Vasut
2024-06-18 7:29 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 07/11] usb: gadget: omap2430: " Marek Vasut
2024-06-14 0:51 ` [PATCH 08/11] usb: gadget: musb: " Marek Vasut
2024-06-18 7:36 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 09/11] usb: gadget: ux500: " Marek Vasut
2024-06-18 7:40 ` Mattijs Korpershoek
2024-06-14 0:51 ` [PATCH 10/11] usb: gadget: sandbox: Drop dm_usb_gadget_handle_interrupts() Marek Vasut
2024-06-18 7:45 ` Mattijs Korpershoek [this message]
2024-06-14 0:51 ` [PATCH 11/11] usb: gadget: Mark dm_usb_gadget_handle_interrupts as non-weak for DM_USB_GADGET Marek Vasut
2024-06-18 7:46 ` Mattijs Korpershoek
2024-06-14 10:24 ` [PATCH 00/11] usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass Sverdlin, Alexander
2024-06-14 14:05 ` Marek Vasut
2024-06-18 7:10 ` Mattijs Korpershoek
2024-07-05 12:10 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzimitiz.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=alexander.sverdlin@siemens.com \
--cc=felipe.balbi@linux.intel.com \
--cc=lukma@denx.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=nm@ti.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox