From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36EE4C07E9B for ; Fri, 9 Jul 2021 05:02:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B049B6135C for ; Fri, 9 Jul 2021 05:02:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B049B6135C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9B657831E9; Fri, 9 Jul 2021 07:02:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C5726831F1; Fri, 9 Jul 2021 07:02:52 +0200 (CEST) Received: from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BDDA831BA for ; Fri, 9 Jul 2021 07:02:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=baruch@tkos.co.il Received: from tarshish (unknown [10.0.8.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 5E36D44086C; Fri, 9 Jul 2021 08:02:46 +0300 (IDT) References: <20210708173032.27999-1-marek.behun@nic.cz> <20210708173032.27999-23-marek.behun@nic.cz> User-agent: mu4e 1.4.15; emacs 27.1 From: Baruch Siach To: Marek =?utf-8?Q?Beh=C3=BAn?= Cc: u-boot@lists.denx.de, Chris Packham , Stefan Roese , Dirk Eibach , Chris Packham , Dennis Gilmore , Mario Six , Jon Nettleton , Pali =?utf-8?Q?Roh=C3=A1r?= Subject: Re: [PATCH u-boot-mvebu 22/31] arm: mvebu: Always use BootROM for loading the rest of U-Boot's binary In-reply-to: <20210708173032.27999-23-marek.behun@nic.cz> Date: Fri, 09 Jul 2021 08:02:47 +0300 Message-ID: <87k0m0uljc.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marek, Pali, On Thu, Jul 08 2021, Marek Beh=C3=BAn wrote: > From: Pali Roh=C3=A1r > > Now that proper load and execution addresses are set in v1 kwbimage, we > can use BootROM to continue loading main U-Boot binary instead of > U-Boot's SPL code. > > This also reduces the size of U-Boot's SPL image. > > The v1 kwbimage contains two separate executable parts: DDR training > code (contains SPL) and bootloader (contains main U-Boot). BootROM first > loads the first part, executes it and expects that the code returns back. > Afterwards it loads the second part and executes it. > > The current SPL code (used for the first part) for non-UART/NAND boots > never returns back to BootROM and loads main U-Boot from external storage > itself, and it lets BootROM think that it is still executing the first > part - DDR training code. > > With this change the SPL always returns execution back to BootROM and > lets BootROM to load and execute U-Boot, like it was already done when > booting from UART and NAND. > > Note that the config options CONFIG_SPL_SPI_FLASH_SUPPORT, > CONFIG_SPL_SPI_LOAD and CONFIG_SPL_SPI_SUPPORT needs to be enabled as > config option CONFIG_SYS_U_BOOT_OFFS (used by kwbimage) depends on it. I think it's worth noting here that a subsequent commit will remove both. baruch --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -