test/image/test-imagetools.sh: Broken by 3f04db89

test/image/test-imagetools.sh: Broken by 3f04db89

[Vagrant Cascadian]

It seems like commit:

3f04db891a353f4b127ed57279279f851c6b4917 image: Check for unit addresses in FIT

Broke test/image/test-imagetools.sh.

I get the impression test-imagetools.sh is more-or-less unmaintained and
deprecated. Does test-imagetools.sh perform tests that are not covered
elsewhere? If it is not maintained (and especially otherwise covered),
it might be worth removing entirely.


Thanks for all your work on u-boot!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210306/9ef5168b/attachment.sig>

test/image/test-imagetools.sh: Broken by 3f04db89

[Simon Glass]

Hi Vagrant,

On Sun, 7 Mar 2021 at 11:50, Vagrant Cascadian <vagrant@debian.org> wrote:
>
> It seems like commit:
>
> 3f04db891a353f4b127ed57279279f851c6b4917 image: Check for unit addresses in FIT
>
> Broke test/image/test-imagetools.sh.
>
> I get the impression test-imagetools.sh is more-or-less unmaintained and
> deprecated. Does test-imagetools.sh perform tests that are not covered
> elsewhere? If it is not maintained (and especially otherwise covered),
> it might be worth removing entirely.
>
>
> Thanks for all your work on u-boot!

It looks like is has useful tests. We should convert it to a python
test in test/py/tests and we already have test_vboot.py which does FIT
things so it should be easy enough.

Regards,
Simon