public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Bugfix: Use only one PTD for one endpoint
Date: Wed, 26 Sep 2007 14:40:14 +0200	[thread overview]
Message-ID: <87k5qdeh1t.fsf@denx.de> (raw)
In-Reply-To: <20070924145032.10fa0782.timo.ketola@exertus.fi> (Timo Ketola's message of "Mon, 24 Sep 2007 14:50:32 +0300")

Hi Timo,

Timo Ketola <timo.ketola@exertus.fi> writes:

> Original isp116x-hcd code prepared multiple PTDs for longer than 16
> byte transfers for one endpoint. That is unnecessary because the
> ISP116x is able to split long data from one PTD into multiple
> transactions based on the buffer size of the endpoint. It also caused
> serious problems if the endpoint NAKed some of the transactions. In
> that case ISP116x wouldn't notice that the other PTDs were for the same
> endpoint and would try the other PTDs possibly out of order. That would
> break the whole transfer.
>
> This patch makes isp116x_submit_job to use one PTD for one transfer.
>
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>

Looks good, please give me a couple of days to test and push to the
USB Custodian repo.

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2007-09-26 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24 11:50 [U-Boot-Users] [PATCH] Bugfix: Use only one PTD for one endpoint Timo Ketola
2007-09-26 12:40 ` Markus Klotzbücher [this message]
2007-10-02  7:54 ` Markus Klotzbücher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5qdeh1t.fsf@denx.de \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox