From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?iso-8859-1?Q?Klotzb=FCcher?= Date: Wed, 26 Sep 2007 14:40:14 +0200 Subject: [U-Boot-Users] [PATCH] Bugfix: Use only one PTD for one endpoint In-Reply-To: <20070924145032.10fa0782.timo.ketola@exertus.fi> (Timo Ketola's message of "Mon, 24 Sep 2007 14:50:32 +0300") References: <20070924145032.10fa0782.timo.ketola@exertus.fi> Message-ID: <87k5qdeh1t.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Timo, Timo Ketola writes: > Original isp116x-hcd code prepared multiple PTDs for longer than 16 > byte transfers for one endpoint. That is unnecessary because the > ISP116x is able to split long data from one PTD into multiple > transactions based on the buffer size of the endpoint. It also caused > serious problems if the endpoint NAKed some of the transactions. In > that case ISP116x wouldn't notice that the other PTDs were for the same > endpoint and would try the other PTDs possibly out of order. That would > break the whole transfer. > > This patch makes isp116x_submit_job to use one PTD for one transfer. > > Signed-off-by: Timo Ketola Looks good, please give me a couple of days to test and push to the USB Custodian repo. Best regards Markus Klotzbuecher -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de