From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?iso-8859-1?Q?Klotzb=FCcher?= Date: Tue, 15 May 2007 10:01:38 +0000 Subject: [U-Boot-Users] [PATCH 2/3] Added USB PCI-OHCI chips support, interrupt pipe support and usb event poll support. In-Reply-To: <46B96294322F7D458F9648B60E15112C234227@zch01exm26.fsl.freescale.net> (Zhang Wei-r's message of "Tue, 15 May 2007 17:02:56 +0800") References: <11774728931751-git-send-email-wei.zhang@freescale.com> <87zm47xy0a.fsf@denx.de> <46B96294322F7D458F9648B60E15112C234179@zch01exm26.fsl.freescale.net> <874pme330n.fsf@denx.de> <46B96294322F7D458F9648B60E15112C234227@zch01exm26.fsl.freescale.net> Message-ID: <87k5va1k3h.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Zhang Wei, "Zhang Wei-r63237" writes: >> So this BE CPU and LE Controller again. The only problem I >> see with your >> fix is that because you _always_ do byteswapping for register accesses >> on BE CPUs, this would break support for the case BE CPU and BE OHCI >> Controller (but which doesn't exist in U-Boot so far). >> >> No need to change this now, because I'm going to clean this >> up soon, but >> I'd appreciate your help in testing once this is done. >> > > I'm using m32_swap(), it is not _always_ do. You can see following > codes in usb_ohci.c: I see, you're right. Still, this mess needs to be cleaned up. I'll start a new thread. Best regards Markus -- DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany