U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Martin Herren <sputnik@on-the-web.ch>, u-boot@lists.denx.de
Cc: Martin Herren <sputnik@on-the-web.ch>,
	Michal Simek <michal.simek@amd.com>,
	Leo Yu-Chi Liang <ycliang@andestech.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Martin Schwan <m.schwan@phytec.de>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Peter Robinson <pbrobinson@gmail.com>,
	Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 2/4] riscv: Set SYS_BOOTM_LEN default to 0x4000000
Date: Mon, 21 Jul 2025 11:21:16 +0200	[thread overview]
Message-ID: <87ldohlx0z.fsf@kernel.org> (raw)
In-Reply-To: <20250719214650.214931-3-sputnik@on-the-web.ch>

Hi Martin,

Thank you for the patch.

On Sat, Jul 19, 2025 at 23:46, Martin Herren <sputnik@on-the-web.ch> wrote:

> This changes the default value to the most commonly used one among
> existing defconfigs.
>
> Acked-by: Michal Simek <michal.simek@amd.com> # xilinx_mbv
> Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
>
> Signed-off-by: Martin Herren <sputnik@on-the-web.ch>

Minor note: there should *not* be a newline between the tags that you
applied (Acked-by, Reviewed-by) and your own sign-off. So the footer
block should be:

"""
    Acked-by: Michal Simek <michal.simek@amd.com> # xilinx_mbv
    Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
    Signed-off-by: Martin Herren <sputnik@on-the-web.ch>
"""

I don't think you need to resend for this, usually the maintainer who
picks up your patch will fix this.

Also:

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>


> ---
>
> (no changes since v1)
>
>  boot/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 2ff6f003738..54ef7052c5c 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -1057,7 +1057,7 @@ config SYS_BOOTM_LEN
>  	hex "Maximum size of a decompresed OS image"
>  	depends on CMD_BOOTM || CMD_BOOTI || CMD_BOOTZ || \
>  		LEGACY_IMAGE_FORMAT || SPL_LEGACY_IMAGE_FORMAT
> -	default 0x4000000 if PPC || ARM64
> +	default 0x4000000 if PPC || ARM64 || RISCV
>  	default 0x1000000 if X86 || ARCH_MX6 || ARCH_MX7
>  	default 0x800000
>  	help

  reply	other threads:[~2025-07-21  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-19 21:46 [PATCH 0/4] Update riscv's SYS_BOOTM_LEN to the most commonly used value Martin Herren
2025-07-19 21:46 ` [PATCH 1/4] riscv: Set SYS_BOOTM_LEN explicitly to 0x800000 Martin Herren
2025-07-19 21:46 ` [PATCH 2/4] riscv: Set SYS_BOOTM_LEN default to 0x4000000 Martin Herren
2025-07-21  9:21   ` Mattijs Korpershoek [this message]
2025-07-19 21:46 ` [PATCH 3/4] riscv: Remove default SYS_BOOTM_LEN from defconfig Martin Herren
2025-07-19 21:46 ` [PATCH 4/4] riscv: Increase Microchip Icicle's SYS_BOOTM_LEN Martin Herren
2025-08-11  8:08   ` Leo Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldohlx0z.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=m.schwan@phytec.de \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=michal.simek@amd.com \
    --cc=pbrobinson@gmail.com \
    --cc=sjg@chromium.org \
    --cc=sputnik@on-the-web.ch \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox