public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
	AKASHI Takahiro <akashi.tkhro@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v2 10/31] test: boot: Use a consistent name for the script bootmeth
Date: Tue, 22 Oct 2024 15:51:41 +0200	[thread overview]
Message-ID: <87ldygutxu.fsf@baylibre.com> (raw)
In-Reply-To: <20241019152211.1014896-11-sjg@chromium.org>

Hi Simon,

Thank you for the patch.

On sam., oct. 19, 2024 at 09:21, Simon Glass <sjg@chromium.org> wrote:

> In the bootflow tests the script bootmeth is bound with the name
> bootmeth_script whereas the others have a name without the bootmeth_
> prefix. Adjust it to be the same.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>
> (no changes since v1)
>
>  test/boot/bootflow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c
> index 154dea70a59..8ea284098e7 100644
> --- a/test/boot/bootflow.c
> +++ b/test/boot/bootflow.c
> @@ -542,7 +542,7 @@ static int prep_mmc_bootdev(struct unit_test_state *uts, const char *mmc_dev,
>  	/* Enable the script bootmeth too */
>  	ut_assertok(uclass_first_device_err(UCLASS_BOOTSTD, &bootstd));
>  	ut_assertok(device_bind(bootstd, DM_DRIVER_REF(bootmeth_2script),
> -				"bootmeth_script", 0, ofnode_null(), &dev));
> +				"script", 0, ofnode_null(), &dev));
>  
>  	/* Enable the cros bootmeth if needed */
>  	if (IS_ENABLED(CONFIG_BOOTMETH_CROS) && bind_cros_android) {
> -- 
> 2.34.1

  reply	other threads:[~2024-10-22 13:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19 15:21 [PATCH v2 00/31] bootstd: Support recording images Simon Glass
2024-10-19 15:21 ` [PATCH v2 01/31] alist: Mention the error condition in alist_add_placeholder() Simon Glass
2024-10-19 15:21 ` [PATCH v2 02/31] alist: Add a comment for alist_init_struct() Simon Glass
2024-10-19 15:21 ` [PATCH v2 03/31] alist: Expand the comment for alist_get() Simon Glass
2024-10-19 15:21 ` [PATCH v2 04/31] alist: Add a way to get the next element Simon Glass
2024-10-19 15:21 ` [PATCH v2 05/31] alist: Add for-loop helpers Simon Glass
2024-10-19 15:21 ` [PATCH v2 06/31] alist: Add a function to empty the list Simon Glass
2024-10-19 15:21 ` [PATCH v2 07/31] alist: Add a way to efficiently filter an alist Simon Glass
2024-10-19 15:21 ` [PATCH v2 08/31] alist: Add maintainer Simon Glass
2024-10-19 15:21 ` [PATCH v2 09/31] dm: core: Add a function to see if a device exists Simon Glass
2024-10-19 15:21 ` [PATCH v2 10/31] test: boot: Use a consistent name for the script bootmeth Simon Glass
2024-10-22 13:51   ` Mattijs Korpershoek [this message]
2024-10-19 15:21 ` [PATCH v2 11/31] bootstd: Move bootflow-adding to bootstd Simon Glass
2024-10-19 15:21 ` [PATCH v2 12/31] bootstd: Move bootflow-clearing " Simon Glass
2024-10-19 15:21 ` [PATCH v2 13/31] bootstd: Add a function to get bootstd only if available Simon Glass
2024-10-19 15:21 ` [PATCH v2 14/31] bootstd: Drop the bootdev-specific list of bootflows Simon Glass
2024-10-19 15:21 ` [PATCH v2 15/31] bootstd: Move the bootflow list into an alist Simon Glass
2024-10-19 15:21 ` [PATCH v2 16/31] test: Expand implementation of ut_list_has_dm_tests() Simon Glass
2024-10-19 15:21 ` [PATCH v2 17/31] test: Drop the duplicate line in setup_bootmenu_image() Simon Glass
2024-10-19 15:21 ` [PATCH v2 18/31] test: boot: Update bootflow_iter() for console checking Simon Glass
2024-10-19 15:21 ` [PATCH v2 19/31] bootstd: cros: Correct the x86-setup address Simon Glass
2024-10-19 15:22 ` [PATCH v2 20/31] bootstd: Maintain a list of images Simon Glass
2024-10-19 15:22 ` [PATCH v2 21/31] bootstd: Update bootmeth_alloc_file() to record images Simon Glass
2024-10-19 15:22 ` [PATCH v2 22/31] boot: pxe: Drop the duplicate comment on get_pxe_file() Simon Glass
2024-10-19 15:22 ` [PATCH v2 23/31] bootmeth_efi: Simplify reading files by using the common function Simon Glass
2024-10-21 10:25   ` Ilias Apalodimas
2024-10-19 15:22 ` [PATCH v2 24/31] bootmeth: Update the read_file() method to include a type Simon Glass
2024-10-22 13:55   ` Mattijs Korpershoek
2024-10-19 15:22 ` [PATCH v2 25/31] bootmeth_efi: Check the filename-allocation in the network path Simon Glass
2024-10-19 15:22 ` [PATCH v2 26/31] boot: Update extlinux pxe_getfile_func() to include type Simon Glass
2024-10-19 15:22 ` [PATCH v2 27/31] boot: Update pxe bootmeth to record images Simon Glass
2024-10-19 15:22 ` [PATCH v2 28/31] Update bootmeth_alloc_other() " Simon Glass
2024-10-19 15:22 ` [PATCH v2 29/31] bootstd: Avoid showing an invalid buffer address Simon Glass
2024-10-19 15:22 ` [PATCH v2 30/31] bootstd: Update cros bootmeth to record images Simon Glass
2024-10-19 15:22 ` [PATCH v2 31/31] bootstd: Add a simple command to list images Simon Glass
2024-10-19 16:31 ` [PATCH v2 00/31] bootstd: Support recording images Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldygutxu.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=akashi.tkhro@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox