From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E80ECC77B61 for ; Fri, 7 Apr 2023 13:26:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F7FF85D2F; Fri, 7 Apr 2023 15:26:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="tHYn6u1h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D196185D2F; Fri, 7 Apr 2023 15:26:53 +0200 (CEST) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 668F485DB6 for ; Fri, 7 Apr 2023 15:26:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wr1-x42c.google.com with SMTP id h17so42294346wrt.8 for ; Fri, 07 Apr 2023 06:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1680874010; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=gBMJbllHKQk2xYSp/FzqWkJpNi+J60tOPTmCF4pdbgk=; b=tHYn6u1hf20oFX4p7ruNpojEhc6NVoPNEIR0cX2MGOf2Enq/jqXTbKbQ0u9jCIeqXG RApavF/QgrRo0+v7TqUn7g/R8EHJE1y7XGz8vrYbs6zzLMRZe1ErwAAeR4W/ej63mFzF m3RPhFN0pTzbdektDgudZRIyhJsj9mTBMQW8ByJRWFAdF5lu3jzwrL9W+ug7Hjt/5xp2 ITEBdHAFgZRpYB0QIfnuk/5bP8dObyzF9nK/GphDDPgWIfZgr2WXo8RpITEUXpdHATPT XiZu+QfFSDNTJzBnI/VLsOrXDfcIisSi6bCP5VWAk9I37+IExGZMLFas/Fu+zDgyrP+P Icgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680874010; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gBMJbllHKQk2xYSp/FzqWkJpNi+J60tOPTmCF4pdbgk=; b=77GR6yRqXEVCaitXaJA1PTcBV2Hitdv+X/FN9oTt+oYEqAHPFiuztt4fvayqckBRaX JsAUQFxO23qPG4Jr8PE+gdvmvXS2hQbMsphzmAKde0SoaXydr5YfW0FZSnJzGyG3QhQq 6dWkoGk9FULauuUo7b8QrLQga7lFyixMTsW7Qw45kztwem4NLjgzipo4t+GQi7XDOUm9 BxLmskcEp58N/4/ST37Ir20gFbvafp6xiuidN61CfEIWKWNddUlIIB4Le5zVINneraGS AMtkG2IGUSCFpbo75QvDiPloRix9jGgKx5ZbrEG/A6KSdqNm6I0otpGADSXHH3PDVnyp rXgA== X-Gm-Message-State: AAQBX9cESci7Xnd1o5DmxX+jQ3oMFvu1f5qfpioIumvRfG+g9PKEsbAk zHqemaFDv926LagciyjZftqCGw== X-Google-Smtp-Source: AKy350baDEAnCdODfrKQJwZw5hkCpAw1iZm7BYEroNp7RK6mY8QsKkV5rqzt8zWCMv1QM+DLkHhTPA== X-Received: by 2002:adf:efc6:0:b0:2cf:e8f4:d1ea with SMTP id i6-20020adfefc6000000b002cfe8f4d1eamr1295005wrp.29.1680874009664; Fri, 07 Apr 2023 06:26:49 -0700 (PDT) Received: from localhost ([2a01:cb19:85e6:1900:2bf7:7388:731d:c4e1]) by smtp.gmail.com with ESMTPSA id o13-20020a5d62cd000000b002c70ce264bfsm4556632wrv.76.2023.04.07.06.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 06:26:49 -0700 (PDT) From: Mattijs Korpershoek To: Sjoerd Simons , u-boot@lists.denx.de Cc: Angus Ainslie , Kunihiko Hayashi , Marek Vasut Subject: Re: [PATCH v2 5/8] usb: dwc3: Add dwc3 glue driver for am62 In-Reply-To: <20230406185542.1179073-6-sjoerd@collabora.com> References: <20230406185542.1179073-1-sjoerd@collabora.com> <20230406185542.1179073-6-sjoerd@collabora.com> Date: Fri, 07 Apr 2023 15:26:48 +0200 Message-ID: <87lej3g6w7.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On jeu., avril 06, 2023 at 20:55, Sjoerd Simons wrote: > Add glue code for TI AM62 to the dwc3 driver; Most code adopted from > TI vendor u-boot code. > > Signed-off-by: Sjoerd Simons Reviewed-by: Mattijs Korpershoek nitpick (comment typo) below > > --- > > Changes in v2: > - Switch dwc3 glue to a seperate driver rather then in dwc-generic > > drivers/usb/dwc3/Kconfig | 14 ++++ > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-am62.c | 127 +++++++++++++++++++++++++++++++++++ > 3 files changed, 142 insertions(+) > create mode 100644 drivers/usb/dwc3/dwc3-am62.c > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index c0c8c16fd9c..26a1e1770c5 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -37,6 +37,20 @@ config SPL_USB_DWC3_GENERIC > Select this for Xilinx ZynqMP and similar Platforms. > This wrapper supports Host and Peripheral operation modes. > > +config SPL_USB_DWC3_AM62 > + bool "TI AM62 USB wrapper" > + depends on SPL_DM_USB && SPL_USB_DWC3_GENERIC > + help > + Select this for TI AM62 Platforms. > + This wrapper supports Host and Peripheral operation modes. > + > +config USB_DWC3_AM62 > + bool "TI AM62 USB wrapper" > + depends on DM_USB && USB_DWC3_GENERIC > + help > + Select this for TI AM62 Platforms. > + This wrapper supports Host and Peripheral operation modes. > + > config USB_DWC3_MESON_G12A > bool "Amlogic Meson G12A USB wrapper" > depends on DM_USB && USB_DWC3 && ARCH_MESON > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index 97b4f7191ca..a46b6824ab7 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -6,6 +6,7 @@ dwc3-y := core.o > > obj-$(CONFIG_USB_DWC3_GADGET) += gadget.o ep0.o > > +obj-$(CONFIG_$(SPL_)USB_DWC3_AM62) += dwc3-am62.o > obj-$(CONFIG_USB_DWC3_OMAP) += dwc3-omap.o > obj-$(CONFIG_USB_DWC3_MESON_G12A) += dwc3-meson-g12a.o > obj-$(CONFIG_USB_DWC3_MESON_GXL) += dwc3-meson-gxl.o > diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c > new file mode 100644 > index 00000000000..20d99758b4f > --- /dev/null > +++ b/drivers/usb/dwc3/dwc3-am62.c > @@ -0,0 +1,127 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * TI AM62 specific glue layer for DWC3 > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "dwc3-generic.h" > + > +void dwc3_ti_am62_glue_configure(struct udevice *dev, int index, > + enum usb_dr_mode mode) > +{ > +#define USBSS_MODE_CONTROL 0x1c > +#define USBSS_PHY_CONFIG 0x8 > +#define USBSS_PHY_VBUS_SEL_MASK GENMASK(2, 1) > +#define USBSS_PHY_VBUS_SEL_SHIFT 1 > +#define USBSS_MODE_VALID BIT(0) > +#define PHY_PLL_REFCLK_MASK GENMASK(3, 0) > +static const int dwc3_ti_am62_rate_table[] = { /* in KHZ */ > + 9600, > + 10000, > + 12000, > + 19200, > + 20000, > + 24000, > + 25000, > + 26000, > + 38400, > + 40000, > + 58000, > + 50000, > + 52000, > +}; > + > + struct clk usb2_refclk; > + int rate_code, i, ret; > + unsigned long rate; > + u32 reg; > + void *usbss; > + bool vbus_divider; > + struct regmap *syscon; > + struct ofnode_phandle_args args; > + > + usbss = dev_remap_addr_index(dev, 0); > + if (IS_ERR(usbss)) { > + dev_err(dev, "can't map IOMEM resource\n"); > + return; > + } > + > + ret = clk_get_by_name(dev, "ref", &usb2_refclk); > + if (ret) { > + dev_err(dev, "can't get usb2_refclk\n"); > + return; > + } > + > + /* Calcuate the rate code */ s/Calcuate/Calculate > + rate = clk_get_rate(&usb2_refclk); > + rate /= 1000; /* To KHz */ > + for (i = 0; i < ARRAY_SIZE(dwc3_ti_am62_rate_table); i++) { > + if (dwc3_ti_am62_rate_table[i] == rate) > + break; > + } > + > + if (i == ARRAY_SIZE(dwc3_ti_am62_rate_table)) { > + dev_err(dev, "unsupported usb2_refclk rate: %lu KHz\n", rate); > + return; > + } > + > + rate_code = i; > + > + /* Read the syscon property */ > + syscon = syscon_regmap_lookup_by_phandle(dev, "ti,syscon-phy-pll-refclk"); > + if (IS_ERR(syscon)) { > + dev_err(dev, "unable to get ti,syscon-phy-pll-refclk regmap\n"); > + return; > + } > + > + ret = ofnode_parse_phandle_with_args(dev_ofnode(dev), "ti,syscon-phy-pll-refclk", NULL, 1, > + 0, &args); > + if (ret) > + return; > + > + /* Program PHY PLL refclk by reading syscon property */ > + ret = regmap_update_bits(syscon, args.args[0], PHY_PLL_REFCLK_MASK, rate_code); > + if (ret) { > + dev_err(dev, "failed to set phy pll reference clock rate\n"); > + return; > + } > + > + /* VBUS divider select */ > + reg = readl(usbss + USBSS_PHY_CONFIG); > + vbus_divider = dev_read_bool(dev, "ti,vbus-divider"); > + if (vbus_divider) > + reg |= 1 << USBSS_PHY_VBUS_SEL_SHIFT; > + > + writel(reg, usbss + USBSS_PHY_CONFIG); > + > + /* Set mode valid */ > + reg = readl(usbss + USBSS_MODE_CONTROL); > + reg |= USBSS_MODE_VALID; > + writel(reg, usbss + USBSS_MODE_CONTROL); > +} > + > +struct dwc3_glue_ops ti_am62_ops = { > + .glue_configure = dwc3_ti_am62_glue_configure, > +}; > + > +static const struct udevice_id dwc3_am62_match[] = { > + { .compatible = "ti,am62-usb", .data = (ulong)&ti_am62_ops }, > + { /* sentinel */ } > +}; > + > +U_BOOT_DRIVER(dwc3_am62_wrapper) = { > + .name = "dwc3-am62", > + .id = UCLASS_SIMPLE_BUS, > + .of_match = dwc3_am62_match, > + .bind = dwc3_glue_bind, > + .probe = dwc3_glue_probe, > + .remove = dwc3_glue_remove, > + .plat_auto = sizeof(struct dwc3_glue_data), > + > +}; > -- > 2.40.0