From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A91C07E96 for ; Thu, 15 Jul 2021 05:39:15 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B366161360 for ; Thu, 15 Jul 2021 05:39:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B366161360 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A5D2829E7; Thu, 15 Jul 2021 07:39:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 22A1282BC7; Thu, 15 Jul 2021 07:39:11 +0200 (CEST) Received: from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A85AA829E7 for ; Thu, 15 Jul 2021 07:39:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=baruch@tkos.co.il Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 8825A440850; Thu, 15 Jul 2021 08:39:01 +0300 (IDT) References: <20210714143729.2396-1-pali@kernel.org> <20210714143729.2396-3-pali@kernel.org> User-agent: mu4e 1.4.15; emacs 27.1 From: Baruch Siach To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: Stefan Roese , Andre Heider , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin , Fabio Estevam , Peng Fan , u-boot@lists.denx.de Subject: Re: [PATCH 3/3] mmc: mmc_get_op_cond: Allow quiet detection of eMMC In-reply-to: <20210714143729.2396-3-pali@kernel.org> Date: Thu, 15 Jul 2021 08:39:05 +0300 Message-ID: <87lf68rv9i.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On Wed, Jul 14 2021, Pali Roh=C3=A1r wrote: > Add a new 'quiet' argument to mmc_get_op_cond() function which avoids > printing error message when SD/eMMC card is not detected. > > Espressobin and mx6cuboxi boards use this function for detecting presence > of eMMC and therefore it is expected and normal that eMMC does not have to > be connected. So error message "Card did not respond to voltage select!" > should be skipped in this case as it is not an error. > > Signed-off-by: Pali Roh=C3=A1r > --- > board/Marvell/mvebu_armada-37xx/board.c | 2 +- Ordering this patch before #2 would make it smaller. baruch > board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +- > drivers/mmc/mmc.c | 7 ++++--- > include/mmc.h | 3 ++- > 4 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mveb= u_armada-37xx/board.c > index 6086996b8062..fdc873b1952f 100644 > --- a/board/Marvell/mvebu_armada-37xx/board.c > +++ b/board/Marvell/mvebu_armada-37xx/board.c > @@ -124,7 +124,7 @@ int board_late_init(void) >=20=20 > /* eMMC is mmc dev num 1 */ > mmc_dev =3D find_mmc_device(1); > - emmc =3D (mmc_dev && mmc_get_op_cond(mmc_dev) =3D=3D 0); > + emmc =3D (mmc_dev && mmc_get_op_cond(mmc_dev, true) =3D=3D 0); >=20=20 > /* if eMMC is not present then remove it from DM */ > if (!emmc && mmc_dev) { > diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cub= oxi/mx6cuboxi.c > index 3eadc38f6fd4..6207bf8253ab 100644 > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c > @@ -374,7 +374,7 @@ static bool has_emmc(void) > mmc =3D find_mmc_device(2); > if (!mmc) > return 0; > - return (mmc_get_op_cond(mmc) < 0) ? 0 : 1; > + return (mmc_get_op_cond(mmc, true) < 0) ? 0 : 1; > } >=20=20 > int checkboard(void) > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 1e83007286b2..8078a89f18cb 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -2766,7 +2766,7 @@ static int mmc_power_cycle(struct mmc *mmc) > return mmc_power_on(mmc); > } >=20=20 > -int mmc_get_op_cond(struct mmc *mmc) > +int mmc_get_op_cond(struct mmc *mmc, bool quiet) > { > bool uhs_en =3D supports_uhs(mmc->cfg->host_caps); > int err; > @@ -2842,7 +2842,8 @@ retry: >=20=20 > if (err) { > #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT) > - pr_err("Card did not respond to voltage select! : %d\n", err); > + if (!quiet) > + pr_err("Card did not respond to voltage select! : %d\n", err); > #endif > return -EOPNOTSUPP; > } > @@ -2882,7 +2883,7 @@ int mmc_start_init(struct mmc *mmc) > return -ENOMEDIUM; > } >=20=20 > - err =3D mmc_get_op_cond(mmc); > + err =3D mmc_get_op_cond(mmc, false); >=20=20 > if (!err) > mmc->init_in_progress =3D 1; > diff --git a/include/mmc.h b/include/mmc.h > index 6f943e78b740..0bf19de20e52 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -900,9 +900,10 @@ int mmc_set_bkops_enable(struct mmc *mmc); > * the presence of SD/eMMC when no card detect logic is available. > * > * @param mmc Pointer to a MMC device struct > + * @param quiet Be quiet, do not print error messages when card is not d= etected. > * @return 0 on success, <0 on error. > */ > -int mmc_get_op_cond(struct mmc *mmc); > +int mmc_get_op_cond(struct mmc *mmc, bool quiet); >=20=20 > /** > * Start device initialization and return immediately; it does not block= on --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -